CMake: add BUILD_STANDALONE_PYTHON_INTERFACE option #2714
+298
−178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
👋 Hi,
This is a reminder message to assign an extra build label to this Pull Request if needed.
By default, this PR will be build with minimal build options (URDF support and Python bindings)
The possible extra labels are:
- build_collision (build Pinocchio with coal support)
- build_casadi (build Pinocchio with CasADi support)
- build_autodiff (build Pinocchio with CppAD support)
- build_codegen (build Pinocchio with CppADCodeGen support)
- build_extra (build Pinocchio with extra algorithms)
- build_mpfr (build Pinocchio with Boost.Multiprecision support)
- build_sdf (build Pinocchio with SDF parser)
- build_accelerate (build Pinocchio with APPLE Accelerate framework support)
- build_all (build Pinocchio with ALL the options stated above)
Thanks.
The Pinocchio development team.
6a5b4fa to
601786d
Compare
jcarpent
reviewed
Jun 30, 2025
jcarpent
reviewed
Jun 30, 2025
| @@ -446,10 +450,14 @@ function(ADD_WINDOWS_DLL_PATH_TO_TEST TEST_NAME) | |||
| endfunction() | |||
|
|
|||
| # --- MAIN LIBRARY ------------------------------------------------------------- | |||
| add_subdirectory(src) | |||
| if(NOT BUILD_STANDALONE_PYTHON_INTERFACE) | |||
There was a problem hiding this comment.
I would add a variable called: BUILD_MAIN_PROJECT_AND_ASSOCIATED_OUPUTS
There was a problem hiding this comment.
Do you mean something like this ?
set(BUILD_MAIN_PROJECT_AND_ASSOCIATED_OUPUTS (NOT BUILD_STANDALONE_PYTHON_INTERFACE))
jorisv
requested changes
Jul 8, 2025
jorisv
requested changes
Aug 4, 2025
be83604 to
33565b1
Compare
8199671 to
56b581c
Compare
9a9edb1 to
3841cef
Compare
jorisv
previously approved these changes
Aug 26, 2025
jorisv
previously approved these changes
Aug 26, 2025
jorisv
approved these changes
Aug 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows coal-library/coal#658
Still not tested enough, but it already seems good in multiple tests