Skip to content

Cache references to Array.prototype.filter #1523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 10, 2017
Merged

Cache references to Array.prototype.filter #1523

merged 3 commits into from
Aug 10, 2017

Conversation

fatso83
Copy link
Contributor

@fatso83 fatso83 commented Aug 10, 2017

Purpose

Fixes issue #1521 by caching references to the filter method so that it can be stubbed. Also adds a hint to the pull request template on things that should be in place.

How to verify - mandatory

  1. Check out this branch
  2. npm install
  3. npm test

@fatso83 fatso83 force-pushed the 1521-stub-array-filter-fails branch from 0a9a3e8 to 052a2d0 Compare August 10, 2017 10:31
@fatso83
Copy link
Contributor Author

fatso83 commented Aug 10, 2017

I added no extra tests for the second commit. I simply couldn't find out how to add relevant tests, so I gave up after close to an hour of messing around with call.js and call-test.js, but at least all existing tests pass.

mantoni
mantoni approved these changes Aug 10, 2017
View reviewed changes
Copy link
Member

@mantoni mantoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@fatso83 fatso83 merged commit 81c23fb into sinonjs:master Aug 10, 2017
@mroderick mroderick added the semver:patch changes will cause a new patch version label Aug 10, 2017
@mroderick
Copy link
Member

This has become part of v3.2.0

fatso83 added a commit that referenced this pull request Aug 10, 2017
@fatso83
Fix docs regression introduced by #1523
2a04615
@noisecapella noisecapella mentioned this pull request Aug 10, 2017
Closed
2 tasks
@fatso83 fatso83 deleted the 1521-stub-array-filter-fails branch August 14, 2017 07:45
This was referenced Aug 14, 2017
Merged
Merged
@iilei iilei mentioned this pull request Aug 21, 2017
Merged
2 tasks
@alex94cp alex94cp mentioned this pull request Aug 25, 2017
Merged
2 tasks
@rgroothuijsen rgroothuijsen mentioned this pull request Aug 26, 2017
Merged
2 tasks
@killmenot killmenot mentioned this pull request Sep 3, 2017
Merged
2 tasks
@servel333 servel333 mentioned this pull request Sep 13, 2017
Merged
2 tasks
@vsa vsa mentioned this pull request Sep 18, 2017
Closed
2 tasks
@evan-007 evan-007 mentioned this pull request Oct 2, 2017
Merged
2 tasks
@tarjei tarjei mentioned this pull request Oct 9, 2017
Merged
@dazld dazld mentioned this pull request Oct 13, 2017
Merged
2 tasks
@DevLab2425 DevLab2425 mentioned this pull request Oct 14, 2017
Merged
2 tasks
@avaly avaly mentioned this pull request Oct 14, 2017
Merged
2 tasks
@JakeChampion JakeChampion mentioned this pull request Oct 18, 2017
Merged
2 tasks
@dpmott dpmott mentioned this pull request Oct 30, 2017
Merged
4 tasks
This was referenced Nov 9, 2017
Closed
Merged
@ProLoser ProLoser mentioned this pull request Dec 6, 2017
Merged
2 tasks
@fatso83 fatso83 mentioned this pull request Sep 26, 2023
Merged
@fatso83 fatso83 mentioned this pull request Oct 18, 2023
Merged
@fatso83 fatso83 mentioned this pull request Oct 25, 2023
Closed
2 tasks
This was referenced Oct 31, 2023
Merged
Merged
This was referenced Nov 5, 2023
Closed
Merged
Merged
This was referenced Dec 22, 2023
Merged
Merged
@remorses remorses mentioned this pull request Jan 4, 2024
Closed
2 tasks
This was referenced Jan 5, 2024
Merged
Merged
@Eliyahu-Machluf Eliyahu-Machluf mentioned this pull request Jan 18, 2024
Merged
This was referenced Apr 25, 2024
Merged
Merged
@Rotzbua Rotzbua mentioned this pull request May 28, 2024
Merged
2 tasks
This was referenced Sep 10, 2024
Merged
Merged
Merged
@fatso83 fatso83 mentioned this pull request Oct 30, 2024
Merged
2 tasks
This was referenced Dec 26, 2024
Open
Closed
@mroderick mroderick mentioned this pull request Feb 18, 2025
Merged
This was referenced Mar 17, 2025
Merged
Merged
@abidta abidta mentioned this pull request Mar 20, 2025
Open
2 tasks
@mroderick mroderick mentioned this pull request Jun 9, 2025
Merged
2 tasks
@bmeurer bmeurer mentioned this pull request Jun 17, 2025
Merged
2 tasks
@arturparkhisenko arturparkhisenko mentioned this pull request Jul 2, 2025
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mantoni mantoni mantoni approved these changes

Assignees
No one assigned
Labels
semver:patch changes will cause a new patch version
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fatso83 @mroderick @mantoni