feat: detect QLTY_COVERAGE_TOKEN env var #1139
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello and thank you for SimpleCov!
This PR updates the detection for the
CC_TEST_REPORTER_IDenvironment variable to also detect theQLTY_COVERAGE_TOKENenv var.Context: As of this year, the Code Climate Quality product has been replaced by the newer Qlty Cloud edition. (Qlty Cloud is operated by the same team previously responsible for Code Climate Quality.)
Qlty Cloud uses the
QLTY_COVERAGE_TOKENenv var in the same way that Code Climate Quality usedCC_TEST_REPORTER_ID. This PR ensures JSON code coverage data is automatically generated when it is present.We discovered that some customers are not aware of the
CC_TEST_REPORTER_IDbehavior and when they switched fromCC_TEST_REPORTER_IDtoQLTY_COVERAGE_TOKENit was confusing that the JSON went missing.This PR also preserves the
CC_TEST_REPORTER_IDbehavior for backwards compatibility, for anyone where it may be a "load bearing" behavior.Please let me know if you have any questions about this change!
-Bryan