feat: postgres store #4626
Draft
feat: postgres store #4626
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b298f40 to
fb0dd93
Compare
otavio
reviewed
Mar 26, 2025
api/services/user.go
Outdated
Comment on lines
44
to
57
| if req.Name != "" { | ||
| user.Name = cases.Title(language.AmericanEnglish).String(strings.ToLower(req.Name)) | ||
| } | ||
|
|
||
| if req.Username != "" { | ||
| user.Username = strings.ToLower(req.Username) | ||
| } | ||
|
|
||
| if req.Email != "" { | ||
| user.Email = strings.ToLower(req.Email) | ||
| } | ||
|
|
||
| if req.RecoveryEmail != "" { | ||
| user.Preferences.SecurityEmail = strings.ToLower(req.RecoveryEmail) |
There was a problem hiding this comment.
I think here we can use the previous strategy, which is always to the lowercase function call. The checking seems to be not worth and it complicates the code without a real, probably, good performance gain.
8bc3d90 to
1fb1bed
Compare
1e75d09 to
25d8b30
Compare
877ff84 to
45350b6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.