Skip to content

Patch CVE-2024-42002 #1001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: rolling
Choose a base branch
from
Open

Patch CVE-2024-42002 #1001

wants to merge 6 commits into from

Conversation

mjcarroll
Copy link
Member

Replaces #999

@florcabral @mjcarroll
Patch CVE-2024-42002
0ccb306 
Signed-off-by: Florencia <49619072+florcabral@users.noreply.github.com>
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
@mjcarroll mjcarroll self-assigned this Apr 3, 2025
@mjcarroll mjcarroll requested a review from ahcorde April 3, 2025 13:59
ahcorde and others added 2 commits April 3, 2025 14:05
@ahcorde @mjcarroll
make linters happy
17d4d67 
Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
@mjcarroll
Update message recursive field computation for rolling
1ec1f44 
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
@ahcorde
Copy link
Contributor

ahcorde commented Apr 3, 2025

Pulls: #1001
Gist: https://gist.githubusercontent.com/ahcorde/418d81fdef70ee2209e3fd6c7d23ab9e/raw/5366d57a0db798da244c1205658c21f84aa69ae2/ros2.repos
BUILD args: --packages-above-and-dependencies ros2topic
TEST args: --packages-above ros2topic
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/15571

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@ahcorde
make linters happy
a8da3ac 
Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
@ahcorde ahcorde mentioned this pull request Apr 3, 2025
Closed
mjcarroll added 2 commits April 4, 2025 19:12
@mjcarroll
Lint
78267b9 
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
@mjcarroll
Merge remote-tracking branch 'origin/mjcarroll/reapply_cve_patch' int…
0240e86 
…o mjcarroll/reapply_cve_patch

Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
@mjcarroll mjcarroll force-pushed the mjcarroll/reapply_cve_patch branch from 9a17d3e to 0240e86 Compare April 4, 2025 19:13
@mjcarroll
Copy link
Member Author

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@christophebedard christophebedard mentioned this pull request Apr 4, 2025
Open
@florcabral
Copy link
Contributor

Hi @mjcarroll. I noticed there was a CI issue when merging this CVE patch. Any help needed?

@mjcarroll
Copy link
Member Author

Hey @florcabral if you wouldn't mind taking a look at the CI issues here, I didn't catch them in my local testing before merging.

@florcabral
Copy link
Contributor

florcabral commented May 17, 2025 •
edited
Loading

@mjcarroll Trying to drill down into the actual tests that failed after this patch - am I looking at the right build log here? If so, for ros2topic I see some failures related to tests for the echo verb, but the patch only affected the hz verb, plus some linter issues. I am not seeing any failing tests related to the patch itself. Have you looked into this yourself? Maybe I'm missing something.

@mjcarroll

This comment was marked as outdated.

Sign in to view
@mjcarroll
Copy link
Member Author

Pulls: #1001
Gist: https://gist.githubusercontent.com/mjcarroll/bc4c882cb2e32c4f4fe313f12076b61d/raw/5366d57a0db798da244c1205658c21f84aa69ae2/ros2.repos
BUILD args: --packages-up-to ros2topic
TEST args: --packages-select ros2topic
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/16047

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@mjcarroll
Copy link
Member Author

@florcabral I have rerun the CI, you can see the logs here: https://ci.ros2.org/job/ci_linux-aarch64/17812/testReport/junit/ros2topic.ros2topic.test/test_cli/test_cli/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahcorde ahcorde ahcorde approved these changes

Assignees

@mjcarroll mjcarroll

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mjcarroll @ahcorde @florcabral