fix: dtNavMeshQuery::findRandomPoint should not fail because of getPo… #560
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakobbotsch
reviewed
Oct 12, 2022
Detour/Source/DetourNavMeshQuery.cpp
Outdated
Comment on lines
493
to
498
| dtStatus stat = getPolyHeight(randomPolyRef, pt, &h); | ||
| if (dtStatusFailed(status)) | ||
| return stat; | ||
| pt[1] = h; | ||
|
|
||
| if (dtStatusSucceed(stat)) { | ||
| // otherwise pt is on poly edge | ||
| pt[1] = h; | ||
| } | ||
|
|
There was a problem hiding this comment.
I think this should be switched to closestPointOnPoly instead. Also, can you please undo the whitespace changes (or submit them as a separate fix)? Thanks!
…y::findRandomPoint
jakobbotsch
approved these changes
Oct 13, 2022
|
Thank you! |
onehundredfeet
pushed a commit
to onehundredfeet/recastnavigation
that referenced
this pull request
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #556