Fix #925: inconsistent return in df_integrals.py::double_factorize #1111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `double_factorize` method in the `DFABKpointIntegrals` class had an inconsistent return. It was type-hinted to return `None`, but had a code path that returned a value. This early return also caused a caching issue where the method would incorrectly return a cached result even when called with a new `thresh` value, preventing re-computation. This commit removes the premature return statement, ensuring that the computation is always performed when the method is called. This allows the `thresh` parameter to take effect as intended and makes the method's behavior consistent with its type hint.
…alue (quantumlib#1112) When adding a new term to a `SymbolicOperator` with a sympy coefficient, the coefficient was being cast to a float. This was because the default value for a new term was `0.0`, which is a float. This commit changes the default value to `0`, which is an integer. This ensures that the type of the coefficient is preserved when adding new terms.
dstrain115
approved these changes
Aug 28, 2025
|
I think the actual issue here is that df_factors doesn't seem to be used anywhere... |
I did some searching in the code base, and it looks like you're right. In that case, I propose to change this PR to remove this property from the class – unless you think that we've stumbled on a deeper problem (e.g., that something should be setting the value, but isn't)? |
68c920e to
5fcc1d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
double_factorizemethod in theDFABKpointIntegralsclass had an inconsistent return. It was type-hinted to returnNone, but had a code path that returned a value. This early return also caused a caching issue where the method would incorrectly return a cached result even when called with a newthreshvalue, preventing re-computation.This commit removes the premature return statement. This allows the
threshparameter to take effect as intended and makes the method's behavior consistent with its type hint.