Skip to content

Conversation

Raymo111
Copy link
Member

Use cudaError_t and switch through the enum to prevent impact by upstream changes in wording

@Raymo111 Raymo111 requested a review from q10 July 18, 2025 22:42
@Raymo111 Raymo111 requested a review from eqy as a code owner July 18, 2025 22:42
@Raymo111 Raymo111 added the topic: not user facing topic category label Jul 18, 2025
@Raymo111 Raymo111 requested a review from syed-ahmed as a code owner July 18, 2025 22:42
Copy link

pytorch-bot bot commented Jul 18, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/158688

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit b61d742 with merge base 3bb729d (image):

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@Raymo111 Raymo111 force-pushed the gh/raymo/cuda-error-exp branch from 35b38da to b61d742 Compare July 18, 2025 22:48
@Raymo111
Copy link
Member Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jul 21, 2025
@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: Approvers from one of the following sets are needed:

  • superuser (pytorch/metamates)
  • Core Reviewers (mruberry, lezcano, Skylion007, ngimel, peterbell10, ...)
  • Core Maintainers (soumith, gchanan, ezyang, dzhulgakov, malfet, ...)
Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@Raymo111
Copy link
Member Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

saienduri pushed a commit to saienduri/pytorch that referenced this pull request Jul 22, 2025
…orch#158688)

Use cudaError_t and switch through the enum to prevent impact by upstream changes in wording
Pull Request resolved: pytorch#158688
Approved by: https://github.com/q10, https://github.com/aorenste
@Raymo111 Raymo111 deleted the gh/raymo/cuda-error-exp branch July 23, 2025 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged topic: not user facing topic category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants