Skip to content

Conversation

MSP-Greg
Copy link
Member

Description

See comment, or

Also the order that ivars are set can affect JIT caching. If we are going to set an ivar outside of initialize, we should define it as nil inside of initialize so the order of ivars is the same for every instance.

The above comment was directed at adding @env_set_http_version without initializing it.

I tried to audit whether any other ivars needed the same, and only noticed @reactor.

Your checklist for this pull request

  • I have reviewed the guidelines for contributing to this repository.
  • I have added (or updated) appropriate tests if this PR fixes a bug or adds a feature.
  • My pull request is 100 lines added/removed or less so that it can be easily reviewed.
  • If this PR doesn't need tests (docs change), I added [ci skip] to the title of the PR.
  • If this closes any issues, I have added "Closes #issue" to the PR description or my commit messages.
  • I have updated the documentation accordingly.
  • All new and existing tests passed, including Rubocop.

@MSP-Greg MSP-Greg merged commit 57ca334 into puma:master Aug 29, 2025
74 checks passed
@MSP-Greg MSP-Greg deleted the 00-server-ivar branch August 29, 2025 02:24
@schneems
Copy link
Contributor

FWIW here's the "object shapes" info I was talking about RE that comment https://www.youtube.com/watch?v=0lg9Y8gj3FI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants