Skip to content

Conversation

MSP-Greg
Copy link
Member

Description

As noted in title.

Three commits:

  1. ci: test_error_logger.rb - add test_info_with_request_with_query_param - this commit can be checked out and the added test will fail. Replaced several regex assertions with assert_include
  2. error_logger.rb - fixup QUERY_STRING bug (no ? output) - fixes bug
  3. ci: tests.yml - quote 3.0, otherwise parsed as 3 - GHA yaml parser works differently than Ruby. A version with a trailing zero must be quoted. 3.0 will be interpreted as 3 which currently loads 3.4.z and 3.10, which would load Ruby 3.1.z.

Closes #3625
Closes #3617

@bhooshiek-narendiran and @olleolleolle - sorry, this seemed easier. I listed the two of you as co-authors

  • I have reviewed the guidelines for contributing to this repository.
  • I have added (or updated) appropriate tests if this PR fixes a bug or adds a feature.
  • My pull request is 100 lines added/removed or less so that it can be easily reviewed.
  • If this PR doesn't need tests (docs change), I added [ci skip] to the title of the PR.
  • If this closes any issues, I have added "Closes #issue" to the PR description or my commit messages.
  • I have updated the documentation accordingly.
  • All new and existing tests passed, including Rubocop.

MSP-Greg and others added 3 commits August 28, 2025 12:01
Co-authored-by: bhooshiek <bhooshiek.narendiran@freshworks.com>
Co-authored-by: bhooshiek <bhooshiek.narendiran@freshworks.com>
Co-authored-by: Olle Jonsson <olle.jonsson@gmail.com>
@github-actions github-actions bot added the waiting-for-review Waiting on review from anyone label Aug 28, 2025
assert_includes err, 'GET /debug?b=test" - (8.8.8.8))'
end


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👾 An extra newline we could do without?

Copy link
Contributor

@olleolleolle olleolleolle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️ Nice!

(Totally not important, but inproperlyy in the PR title can also be spelled improperly.)

@MSP-Greg MSP-Greg added the bug label Aug 29, 2025
@MSP-Greg MSP-Greg changed the title :bug Fix error_logger inproperlyy logging env[QUERY_STRING] :bug Fix error_logger inproperly logging env[QUERY_STRING] Aug 29, 2025
@schneems schneems merged commit 4d08ab8 into puma:master Aug 29, 2025
74 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug waiting-for-review Waiting on review from anyone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Puma::ErrorLogger: missing "?" when logging requests with a query string
3 participants