Skip to content

Rename @phased_restart -> @pending_phased_restart #3645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Rename @phased_restart -> @pending_phased_restart #3645

wants to merge 1 commit into from
+6 −6

Conversation

joshuay03
Copy link
Contributor

Description

@toregeschliman provided good reasoning here: #3643 (comment)

Your checklist for this pull request

  • I have reviewed the guidelines for contributing to this repository.
  • I have added (or updated) appropriate tests if this PR fixes a bug or adds a feature.
  • My pull request is 100 lines added/removed or less so that it can be easily reviewed.
  • If this PR doesn't need tests (docs change), I added [ci skip] to the title of the PR.
  • If this closes any issues, I have added "Closes #issue" to the PR description or my commit messages.
  • I have updated the documentation accordingly.
  • All new and existing tests passed, including Rubocop.

@joshuay03 joshuay03 changed the title Rename @phased_restart -> @pending_phased_restart Rename @phased_restart -> @pending_phased_restart Apr 4, 2025
@joshuay03 joshuay03 force-pushed the rename-phased-restart-ivar branch from 9b7672b to 97e838b Compare April 4, 2025 22:46
@joshuay03 joshuay03 mentioned this pull request Apr 4, 2025
Open
7 tasks
@joshuay03 joshuay03 moved this to In Progress / Pending Review in Open Source Apr 4, 2025
@github-actions github-actions bot added the waiting-for-review Waiting on review from anyone label Apr 4, 2025
@joshuay03 joshuay03 force-pushed the rename-phased-restart-ivar branch from 97e838b to 3dc2b8c Compare May 26, 2025 02:04
@joshuay03
Copy link
Contributor Author

@MSP-Greg @dentarg Any objections to this?

@joshuay03 @toregeschliman
Rename @phased_restart -> @pending_phased_restart
0c38f6b 
Co-authored-by: tore g. eschliman <toregeschliman@users.noreply.github.com>
@joshuay03 joshuay03 force-pushed the rename-phased-restart-ivar branch from 3dc2b8c to 0c38f6b Compare August 27, 2025 12:05
@github-actions github-actions bot added waiting-for-merge and removed waiting-for-review Waiting on review from anyone labels Aug 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MSP-Greg MSP-Greg MSP-Greg approved these changes

Assignees
No one assigned
Labels
waiting-for-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joshuay03 @MSP-Greg