override min window size for toolbars #148
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, Many thanks for this fix ! Although the fix is short, I suspect that chasing the source of the issue was a bit more difficult, since it came from external constraints. So, thank you again! Also, sorry for not answering sooner, I was on holiday in August. Don’t worry for the failing checks, they are due to an incompatible older Vcpkg package. |
pthom
approved these changes
Aug 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #147. The issue was that toolbar windows still had a minimum window size imposed by dear imgui, which cause the position and size for the main dock space to be calculated incorrectly.
This is a simple 2-line change which simply overrides the toolbar's minimum window size.