Skip to content

fix(Checkbox): bind value prop to input value attribute #7789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(Checkbox): bind value prop to input value attribute #7789

wants to merge 1 commit into from
+1 −0

Conversation

KumJungMin
Copy link
Contributor

Defect Fixes


How To Resolve

  • The checkbox input was missing the value attribute. (ex. value="Mushroom")
스크린샷 2025-03-16 오후 4 26 24

< primeReact checkbox example >


  • Referring to a similar implementation in the PrimeVue library,
  • the PrimeReact checkbox was updated to bind the value prop to the input's value attribute.
스크린샷 2025-03-16 오후 4 27 39

< primeVue checkbox example >


Test

Before Fix: The input element did not have a value attribute.

스크린샷 2025-03-16 오후 4 26 24



After Fix: The input element's value attribute is correctly assigned from props.value(Mushroom)

스크린샷 2025-03-16 오후 4 30 44

@vercel Vercel
Copy link

vercel bot commented Mar 16, 2025

Deployment failed with the following error:

Creating the Deployment Timed Out.

@melloware
Copy link
Member

I commented in the ticket. This looks intentional by PrimeTek but I am not familiar with why.

@melloware melloware added the Status: Pending Review Issue or pull request is being reviewed by Core Team label Mar 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Pending Review Issue or pull request is being reviewed by Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Checkbox: value prop not being used to populate the input's value attribute
2 participants
@KumJungMin @melloware