Skip to content

Enable KeyringPair Creation with Custom Mnemonic Wordlists #1974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 5, 2025
Merged

Enable KeyringPair Creation with Custom Mnemonic Wordlists #1974

merged 1 commit into from
Feb 5, 2025

Conversation

valentinfernandez1
Copy link
Contributor

@valentinfernandez1 valentinfernandez1 commented Feb 4, 2025 •
edited
Loading

This pull request addresses part 3 of issue #1804. It introduces the capability to create KeyringPair instances using custom mnemonic wordlists, enhancing support for various languages and improving flexibility in key pair generation.

Key Changes:

  • Added functionality to specify custom BIP-39 mnemonic wordlists during KeyringPair creation using addFromMnemonic(), addFromUri() and createFromUri().
  • Updated relevant documentation to reflect the new feature.
  • Included tests to ensure compatibility with different mnemonic wordlists.

closes #1804

@valentinfernandez1 valentinfernandez1 changed the title Allow keyringPair to be created using a mnemonic wordlist Enable KeyringPair Creation with Custom Mnemonic Wordlists Feb 4, 2025
TarikGul
TarikGul approved these changes Feb 5, 2025
View reviewed changes
Copy link
Member

@TarikGul TarikGul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing, nice job 🚀

@TarikGul TarikGul merged commit e25bb48 into master Feb 5, 2025
4 checks passed
@TarikGul TarikGul deleted the feature/bip39-wordlist branch February 5, 2025 11:41
@polkadot-js-bot
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@polkadot-js polkadot-js locked as resolved and limited conversation to collaborators Feb 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@TarikGul TarikGul TarikGul approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for bip39 with other wordlists
3 participants
@valentinfernandez1 @polkadot-js-bot @TarikGul