Skip to content

Conversation

sneridagh
Copy link
Member

@sneridagh sneridagh commented Mar 14, 2025

I was idle, so I give this a try:

@fredvd @ericof based on https://docs.docker.com/build/ci/github-actions/multi-platform/

I don't know how to proceed further, since the merge seems that happens in the registry... I leave this to you then.

@sneridagh sneridagh requested review from fredvd and ericof March 14, 2025 10:39
Copy link
Member

@fredvd fredvd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sneridagh Yes this could work. We talked a while ago on adding a '-next' variant of our 6.1 container images. The discussion was triggered mostly for backend, to update for example relstorage, psycopg and/or the wsgi runner. Then those image setups can also work as test cases for Plone 6.2 when it arrives. plone/plone-backend#167

We should do the same for plone-frontend, where can can test these and other fixed, without them directly impacting the main package releases.

If we merge this to 18.x, I fear we might could send out some partially broken images.

@sneridagh
Copy link
Member Author

@fredvd for tests, yeah, let's add a suffix or whatever because we will need to test it on docker hub. As said, up to you how you want to do it. However, this improvement, is completely aside from the other things that you are mentioning, and the final outcome should be exactly the same as before, only built on the new runners.

@fredvd
Copy link
Member

fredvd commented Mar 14, 2025

Yes, I realise the output should be identical, but it something goes wrong, we'll send out half an image, or with the wrong digest/architectures/etc. Hence the caution . I'll look into it.

We discussed on the plone-backend ticket iirc to create those '-next' builds on a branch, so we don't need to refactor the workflow files and can copy them to a next release branch later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants