Skip to content

Rename Control plane container image & binary to control-plane from pipecd #6090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Aug 13, 2025
Merged

Rename Control plane container image & binary to control-plane from pipecd #6090

merged 6 commits into from
Aug 13, 2025

Conversation

niladrix719
Copy link
Member

@niladrix719 niladrix719 commented Jul 30, 2025 •
edited by ffjlabo
Loading

What this PR does:

Rename container image & binary from pipecd -> control-plane

Why we need it:

To align the container image & binary name with its intended purpose and improve clarity

Which issue(s) this PR fixes:

Part of #5858

@niladrix719
Rename Control plane container image to control-plane from pipecd
fe79e05 
Signed-off-by: “niladrix719” <niladrix719@gmail.com>
@niladrix719 niladrix719 requested a review from a team as a code owner July 30, 2025 12:59
This was referenced Jul 30, 2025
Open
Closed
niladrix719 and others added 2 commits July 30, 2025 19:28
@niladrix719 niladrix719 changed the title Rename Control plane container image to control-plane from pipecd Rename Control plane container image & cmd to control-plane from pipecd Jul 30, 2025
khanhtc1202
khanhtc1202 reviewed Jul 31, 2025
View reviewed changes
manifests/pipecd/values.yaml Outdated
@@ -29,7 +29,7 @@ gateway:

server:
image:
repository: ghcr.io/pipe-cd/pipecd
repository: ghcr.io/pipe-cd/control-plane
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be change later, by separated PR when we introduce control-plane helm chart, since it's the manifest for installing pipecd control-plane via helm

khanhtc1202
khanhtc1202 reviewed Jul 31, 2025
View reviewed changes
manifests/pipecd/values.yaml Outdated
@@ -52,7 +52,7 @@ cache:

ops:
image:
repository: ghcr.io/pipe-cd/pipecd
repository: ghcr.io/pipe-cd/control-plane
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as https://github.com/pipe-cd/pipecd/pull/6090/files#r2244401408

khanhtc1202
khanhtc1202 reviewed Jul 31, 2025
View reviewed changes
quickstart/manifests/control-plane.yaml Outdated
@@ -551,7 +551,7 @@ spec:
done;
containers:
- name: server
image: "ghcr.io/pipe-cd/pipecd:v0.52.2"
image: "ghcr.io/pipe-cd/control-plane:v0.52.2"
Copy link
Member

@khanhtc1202 khanhtc1202 Jul 31, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, I think until we cut the release, this control-plane image tag would not be available. Let's keep using pipecd image until then

khanhtc1202
khanhtc1202 reviewed Jul 31, 2025
View reviewed changes
quickstart/manifests/control-plane.yaml Outdated
@@ -684,7 +684,7 @@ spec:
done;
containers:
- name: ops
image: "ghcr.io/pipe-cd/pipecd:v0.52.2"
image: "ghcr.io/pipe-cd/control-plane:v0.52.2"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as https://github.com/pipe-cd/pipecd/pull/6090/files#r2244403206

khanhtc1202
khanhtc1202 reviewed Jul 31, 2025
View reviewed changes
Copy link
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I left some comments, mostly around the manifests change since it's related to the helm chart (which we have not yet covered by the change in this PR).

Also, I recommend to run makefile command on local to test the build (binary and container image)

@niladrix719
reverted some renaming
ea87cb3 
Signed-off-by: “niladrix719” <niladrix719@gmail.com>
@niladrix719 niladrix719 changed the title Rename Control plane container image & cmd to control-plane from pipecd Rename Control plane container image & binary to control-plane from pipecd Jul 31, 2025
@niladrix719
Copy link
Member Author

I've checked both the container image and binary are working correctly

Screenshot 2025-07-31 at 2 46 15 PM Screenshot 2025-07-31 at 2 39 50 PM

niladrix719 and others added 2 commits July 31, 2025 14:47
@niladrix719
updated readme
c244771 
Signed-off-by: “niladrix719” <niladrix719@gmail.com>
@niladrix719
Merge branch 'master' into rename-cont-img-control-plane#5858
861aed1
@niladrix719 niladrix719 requested a review from khanhtc1202 July 31, 2025 09:19
khanhtc1202
khanhtc1202 reviewed Jul 31, 2025
View reviewed changes
Makefile
helm -n pipecd upgrade --install pipecd .artifacts/pipecd-$(BUILD_VERSION).tgz --create-namespace \
--set server.image.repository=localhost:5001/pipecd \
--set ops.image.repository=localhost:5001/pipecd \
helm -n pipecd upgrade --install control-plane .artifacts/pipecd-$(BUILD_VERSION).tgz --create-namespace \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: We need to update this after introducing chart name control-plane (separated PR)

khanhtc1202
khanhtc1202 approved these changes Jul 31, 2025
View reviewed changes
Copy link
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you 💯

ffjlabo
ffjlabo approved these changes Aug 13, 2025
View reviewed changes
Copy link
Member

@ffjlabo ffjlabo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ffjlabo ffjlabo merged commit 12361db into pipe-cd:master Aug 13, 2025
39 checks passed
@khanhtc1202
Copy link
Member

👋 @niladrix719 Thanks for the contribution! Since this PR has been merged, we can start the second step, which is to make the new chart name control-plane. The current make run/control-plane command refers to using a template under the manifests/pipecd directory, which refers to some service names incorrectly (using the name pipecd of the chart as a reference name for the selector), thus we can't access the pipecd control-plane via the port-forward command.

@niladrix719
Copy link
Member Author

niladrix719 commented Aug 13, 2025 •
edited
Loading

👋 @niladrix719 Thanks for the contribution! Since this PR has been merged, we can start the second step

Hey @khanhtc1202 sure, I have updated PR for the Helm chart renaming - #6020, and docs - #6073 Let me know if we need anything else

@khanhtc1202
Copy link
Member

@niladrix719 Thanks for the detailed information. We will revert this PR first to cut the new release v0.53.0 and re-merge it later, since all 3 PRs should be merged at a time to reduce the risk of breaking the service.

@khanhtc1202 khanhtc1202 mentioned this pull request Aug 14, 2025
Merged
@github-actions github-actions bot mentioned this pull request Aug 15, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khanhtc1202 khanhtc1202 khanhtc1202 approved these changes

@ffjlabo ffjlabo ffjlabo approved these changes

@Warashi Warashi Awaiting requested review from Warashi Warashi is a code owner automatically assigned from pipe-cd/pipecd-approvers

@t-kikuc t-kikuc Awaiting requested review from t-kikuc t-kikuc is a code owner automatically assigned from pipe-cd/pipecd-approvers

Assignees
No one assigned
Labels
area/build area/go
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@niladrix719 @khanhtc1202 @ffjlabo