Skip to content

Conversation

hongky-1994
Copy link
Contributor

What this PR does:

  • This MR depends on Redux replace deployment trace pages #5955
  • Add commandContext for tracing command
  • split util function from modules/deployment
  • add query for get deployment by id, stage logs, command
  • add mutation for cacnel deployment, approve stage, skip stage

Why we need it:

  • remove redux module from deployment-detail pages

Which issue(s) this PR fixes:

Partof #5868

Does this PR introduce a user-facing change?: no

  • How are users affected by this change: no
  • Is this breaking change: no
  • How to migrate (if breaking change): no

Copy link

codecov bot commented Jul 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 28.78%. Comparing base (bc292f2) to head (5f1f3c9).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5972   +/-   ##
=======================================
  Coverage   28.77%   28.78%           
=======================================
  Files         559      559           
  Lines       59521    59521           
=======================================
+ Hits        17127    17131    +4     
+ Misses      41079    41076    -3     
+ Partials     1315     1314    -1     
Flag Coverage Δ
. 23.24% <ø> (ø)
.-pkg-app-pipedv1-plugin-analysis 32.64% <ø> (ø)
.-pkg-app-pipedv1-plugin-kubernetes 60.24% <ø> (ø)
.-pkg-app-pipedv1-plugin-kubernetes_multicluster 67.48% <ø> (ø)
.-pkg-app-pipedv1-plugin-scriptrun 54.83% <ø> (ø)
.-pkg-app-pipedv1-plugin-terraform 39.49% <ø> (ø)
.-pkg-app-pipedv1-plugin-wait 35.51% <ø> (ø)
.-pkg-app-pipedv1-plugin-waitapproval 55.73% <ø> (ø)
.-pkg-plugin-sdk 50.37% <ø> (+0.19%) ⬆️
.-tool-actions-gh-release 19.23% <ø> (ø)
.-tool-actions-plan-preview 25.51% <ø> (ø)
.-tool-codegen-protoc-gen-auth 0.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@hongky-1994 hongky-1994 force-pushed the redux-replace-deployment-detail branch from 69aeb85 to 753c8bf Compare July 28, 2025 07:41
Copy link
Contributor

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

- remove modules/deploymentTrace
- add query for get deployment traces infinitite

Signed-off-by: kypham <hongkyhvnh@gmail.com>
- Add command context for tracing command
- split util function from modules/deployment
  - find-default-active-stage-in-deployment
  - is-deployment-running
  - is-stage-running
- add query for get deployment by id, stage logs, command
- add mutation for cacnel deployment, approve stage, skip stage
- update prop component in detail-page
- update test case

Signed-off-by: kypham <hongkyhvnh@gmail.com>
@hongky-1994 hongky-1994 force-pushed the redux-replace-deployment-detail branch from 753c8bf to 5f1f3c9 Compare September 3, 2025 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant