PS-10131 [8.4] Fix audit log rotation stall in buffered strategies #5683
+3
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix stall during audit log rotation when using ASYNCHRONOUS or PERFORMANCE buffering strategies. The rotation process could be delayed by up to one second while holding the m_write_lock mutex. ``` mysql> do audit_log_rotate(); Query OK, 0 rows affected (0.99 sec) ``` The issue occurs when log rotation calls FileWriterBuffering::close() and the flush worker thread was sleeping in mysql_cond_timedwait. The close method waits for the flush worker to clear the buffer, but that worker thread might not wake up for up to one second causing unnecessary delay. Signal the flush worker thread immediately before waiting in close to ensure prompt processing of any remaining buffered data and prevent rotation stalls.
2afe0e1 to
fd741f4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix stall during audit log rotation when using ASYNCHRONOUS or PERFORMANCE buffering strategies. The rotation process could be delayed by up to one second while holding the m_write_lock mutex.
The issue occurs when log rotation calls FileWriterBuffering::close() and the flush worker thread was sleeping in mysql_cond_timedwait. The close method waits for the flush worker to clear the buffer, but that worker thread might not wake up for up to one second causing unnecessary delay.
Signal the flush worker thread immediately before waiting in close to ensure prompt processing of any remaining buffered data and prevent rotation stalls.