Skip to content

accelerated primary udn management port support #5534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

accelerated primary udn management port support #5534

wants to merge 4 commits into from

Conversation

cathy-zhou
Copy link
Contributor

📑 Description

Fixes #

Additional Information for reviewers

✅ Checks

  • My code requires changes to the documentation
  • if so, I have updated the documentation as required
  • My code requires tests
  • if so, I have added and/or updated the tests as required
  • All the tests have passed in the CI

How to verify it

@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Aug 29, 2025 •
edited
Loading

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot added the area/unit-testing Issues related to adding/updating unit tests label Aug 29, 2025
@cathy-zhou cathy-zhou force-pushed the pudnMgmtPort branch 2 times, most recently from 3cbb084 to cb3613b Compare August 29, 2025 07:03
@coveralls
Copy link

coveralls commented Aug 29, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 17503911127

Details

  • 234 of 808 (28.96%) changed or added relevant lines in 13 files are covered.
  • 38 unchanged lines in 9 files lost coverage.
  • Overall coverage decreased (-0.3%) to 54.6%
Changes Missing Coverage Covered Lines Changed/Added Lines %
go-controller/pkg/config/config.go 1 3 33.33%
go-controller/pkg/node/managementport/port_linux.go 8 11 72.73%
go-controller/pkg/node/managementport/port_dpu_linux.go 9 13 69.23%
go-controller/pkg/node/gateway_udn.go 20 29 68.97%
go-controller/pkg/node/default_node_network_controller.go 0 10 0.0%
go-controller/pkg/node/user_defined_node_network_controller.go 3 15 20.0%
go-controller/pkg/util/sriovnet_linux.go 0 14 0.0%
go-controller/pkg/node/managementport/utils_linux.go 103 129 79.84%
go-controller/pkg/util/net_linux.go 0 27 0.0%
go-controller/pkg/util/node_annotations.go 25 57 43.86%
Files with Coverage Reduction New Missed Lines %
go-controller/pkg/node/default_node_network_controller.go 1 26.4%
go-controller/pkg/node/managementport/port_dpu_linux.go 1 64.71%
go-controller/pkg/ovn/egressqos.go 2 77.49%
go-controller/pkg/ovn/hybrid.go 2 76.4%
go-controller/pkg/node/gateway_udn.go 3 71.5%
go-controller/pkg/node/managementport/port_linux.go 3 72.15%
go-controller/pkg/ovn/egressip.go 3 67.81%
go-controller/pkg/ovn/controller/network_qos/network_qos_namespace.go 4 64.89%
go-controller/pkg/ovn/controller/network_qos/network_qos.go 19 62.43%
Totals Coverage Status
Change from base Build 17492764931: -0.3%
Covered Lines: 38966
Relevant Lines: 71366
💛 - Coveralls

@cathy-zhou
VF backed management port for primary udn
b2a7538 
Signed-off-by: Yun Zhou <yunz@nvidia.com>
@cathy-zhou
fix nodeControllerManager unit test
3bc7c76 
Signed-off-by: Yun Zhou <yunz@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area/unit-testing Issues related to adding/updating unit tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cathy-zhou @coveralls