Skip to content

Fix Python 2.7 CentOS issue by requiring argparse only in Py2.6 #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Fix Python 2.7 CentOS issue by requiring argparse only in Py2.6 #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
4faf5ae
Merge pull request #2 from avengerpenguin/add-loadavg
avengerpenguin Sep 8, 2015
0653391
Merge pull request #3 from osiegmar/master
avengerpenguin Apr 3, 2018
9dcdb06
Only require argparse in Python 2.6 as this actually breaks Py27 in C…
avengerpenguin Apr 3, 2018
b7255ed
Merge pull request #4 from avengerpenguin/centos-issue
avengerpenguin Apr 3, 2018
b50c1a8
Only check major/minor part of Python version info
avengerpenguin Jan 16, 2019
7f927f7
Only check major/minor part of Python version info
avengerpenguin Jan 16, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
#!/usr/bin/env python
from cloudwatchmon import VERSION
import os.path

import sys
from setuptools import find_packages, setup


Expand All @@ -12,6 +12,13 @@ def readme():
return f.read()


requires = ['boto>=2.33.0',]


if sys.version_info[:2] == (2, 6):
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for my late response, I weren't notified via email for this PR.

I doubt this is enough as this is probably also required for Python < 2.7 and < 3.2.

requires += ['argparse']


setup(name='cloudwatchmon',
version=VERSION,
description='Linux monitoring scripts for CloudWatch',
Expand All @@ -23,7 +30,7 @@ def readme():
keywords="monitoring cloudwatch amazon web services aws ec2",
zip_safe=True,
packages=find_packages(),
install_requires=['boto>=2.33.0', 'argparse'],
install_requires=requires,
entry_points={'console_scripts': [
'mon-get-instance-stats.py=cloudwatchmon.cli.get_instance_stats:main',
'mon-put-instance-stats.py=cloudwatchmon.cli.put_instance_stats:main',
Expand Down
4 changes: 4 additions & 0 deletions tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
[tox]
envlist = py26,py27,py33,py34,py35,py36
[testenv]
commands=mon-get-instance-stats.py --version