Skip to content

do not propagate IOException from the MetricsServlet #4832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 29, 2025
Merged

do not propagate IOException from the MetricsServlet #4832

merged 1 commit into from
Aug 29, 2025

Conversation

vladak
Copy link
Member

@vladak vladak commented Aug 29, 2025

Fixes an issue found by SonarCube:

Catching exceptions within the servlet allows us to convert them into meaningful, user-friendly messages. Otherwise, failing to catch exceptions will propagate them to the servlet container, where the default error-handling mechanism may impact the overall security and stability of the server.

@vladak vladak added the webapp web application label Aug 29, 2025
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Aug 29, 2025
@vladak vladak force-pushed the servlet_vs_exception branch from b4c9563 to 50fa08a Compare August 29, 2025 08:32
@vladak vladak changed the title do not propagate IOException from the servlet do not propagate IOException from the MetricsServlet Aug 29, 2025
@vladak vladak merged commit 6ac452e into oracle:master Aug 29, 2025
10 checks passed
@vladak vladak deleted the servlet_vs_exception branch August 29, 2025 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement. webapp web application
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@vladak