[feature] Estimated location creation #1067

DragnEmperor · 2025-06-12T20:25:14Z

Checklist

I have read the OpenWISP Contributing Guidelines.
I have manually tested the changes proposed in this pull request.
I have written new test cases for new code and/or updated existing tests for changes to existing code.
I have updated the documentation.

Reference to Existing Issue

Closes #1034.

Description of Changes

Fuzzy locations task is added to allow creation of such locations when WhoIs is created for the same device. Also the task should attach the device to an existing location if already WhoIs is available for that device.

Scenarios for estimated locations:

When a device has last_ip having no WHOIS record, then the WHOIS record should be created and a new location should be created for the device. The location must be updated with latest coordinates when last_ip of device is updated.
When a device (A) has last_ip, which has WHOIS record, then the location of existing device (B) of same ip should be attached to device A, if:
- A either has no location or A's location is estimated. If either fails, then location should be created/updated using coordinates from WHOIS record
- there is only one existing device with location. In case there are multiple devices with same last_ip and they have locations then a notification must be sent to user notifying them for the same and asking them to resolve this manually.
  In case A has a location which is estimated then it should be deleted before attaching an already existing location.
If two devices A and B have same last_ip which implies they are attached to same location then if either device updates their last_ip (suppose A does) then A should have a new location created with the coordinates for the latest last_ip.

openwisp_controller/config/whois/service.py

devkapilbansal · 2025-07-01T16:00:29Z

openwisp_controller/config/whois/service.py

        """

        # Check cheap conditions first before hitting the database
        if not self.is_valid_public_ip_address(new_ip):
-            return False
+            return False, False


I believe that we should not club this logic here. Although you added the comment, but still name of the function doesn't explain why we are returning two booleans. Can't we create one more function to check if WHOIS info exist?

These checks are dependent on each other. We need to trigger the task when WHOIS already exists for an IP. I will still look into this to find another approach

Agreed, we should not change the return type for this function.

devkapilbansal · 2025-07-01T16:03:38Z

openwisp_controller/config/whois/service.py

            transaction.on_commit(
                lambda: fetch_whois_details.delay(
                    device_pk=self.device.pk,
                    initial_ip_address=self.device._initial_last_ip,
                    new_ip_address=self.device.last_ip,
                )
            )
+        elif whois_info_exists and self.is_whois_enabled:


WHOIS information should exist only when WHOIS is enabled. Do you mean that if WHOIS is disabled after checksum occurs and WHOIS info is added in DB? What are the consequences if we show fuzzy location for that last_ip only whether WHOIS is enabled or not?

I do not think we are deleting existing WHOIS information if WHOIS is disabled for an organization as for some org it may be enabled, we are just not adding that information for that org's device admin and api endpoints.

This check above is to tackle the early fallback when the above condition for fetch_whois_details fail as WHOIS already exists. The task manage_fuzzy_locations in that case will attach the location of an already existing device having same ip to current device. I have defined this behavior in the task's docstring

Also IMO there should not be a problem if fuzzy locations exist irrespective of WHOIS is enabled or not as it just informs the approximate nature of the location. But still if we need to make any changes to fuzzy locations based on WHOIS enabled or not please let me know.

coveralls · 2025-07-01T20:33:29Z

coverage: 98.602% (-0.003%) from 98.605%
when pulling 563bb4a on issues/1034-fuzzy-location-creation
into 41e0b55 on gsoc25-whois.

codesankalp

Should we put fuzzy location creation behind a flag? I’m asking because I’m not sure every organization with WHOIS enabled will need it.

codesankalp · 2025-07-02T20:59:00Z

openwisp_controller/config/whois/tasks.py

+
+
+@shared_task
+def manage_fuzzy_locations(


Could you simplify this function? It looks like it has too many conditional statements. Also, why aren’t we leveraging the service layer here?

I will try to make this function more simpler.
Apologies but I am not sure how should i use the service layer here. Also, service file imports this file so we will encounter circular imports if using service here as well

codesankalp · 2025-07-02T20:59:52Z

openwisp_controller/config/whois/service.py

        """

        # Check cheap conditions first before hitting the database
        if not self.is_valid_public_ip_address(new_ip):
-            return False
+            return False, False


Agreed, we should not change the return type for this function.

codesankalp · 2025-07-02T21:04:40Z

openwisp_controller/config/whois/tasks.py

+    current_location = device_location.location
+    if add_existing and (not current_location or current_location.is_approximate):
+        existing_device_location = (
+            Device.objects.select_related("devicelocation")


Should we filter to the current organization’s devices first, rather than checking every device?

DragnEmperor · 2025-07-03T18:47:15Z

Should we put fuzzy location creation behind a flag? I’m asking because I’m not sure every organization with WHOIS enabled will need it.

We might have to change some things based on how this feature is expected to work. For instance, do we want this to be a complete separate feature than WHOIS lookup (which will require more changes) or a feature which can be enabled/disabled only if WHOIS is enabled.
P.S. : This is dependent on details of latitude and longitude which we get from WHOIS lookup.

Update: There is also a case which is not handled:

when a device's new last_ip already has WHOIS record
we try create/update its fuzzy location using the location of existing device having that same last_ip but somehow location of that device does not exists/ deleted by user

In that case we might need to perform WHOIS lookup again which might be a bit costly as per rate limiting of 1000 requests per day. We can change the WHOIS model to store latitude and longitude information as well to ensure we need not perform a lookup again.

Let me know your thoughts!

devkapilbansal

Need to check the logic for manage_fuzzy_locations once again along with tests. Rest looks good. Have some minor suggestions

devkapilbansal · 2025-07-08T17:02:35Z

openwisp_controller/config/whois/service.py

+        # we are only checking for 2 of the above conditions of `_need_whois_lookup`
+        # as we need to ensure that the fuzzy locations are managed only if there is
+        # existing WHOIS record


This comment looks confusing to me, we are managing fuzzy locations in fetch_whois_details task also

I have updated the comment for better clarity

devkapilbansal · 2025-07-08T17:07:58Z

openwisp_controller/config/whois/tasks.py

+    - If attaching existing location and current device has no location then the
+    existing location is attached to the current device as well.
+    - If attaching existing location and current device already has location, then
+    current device's location is deleted and set same as existing device's location.
+    - If not attaching existing then new location is created if no location exists for
+    current device, or existing one is updated if it is approximate(fuzzy).


Maybe, we can re-write this comment to something more readable like

Suggested change

- If attaching existing location and current device has no location then the

existing location is attached to the current device as well.

- If attaching existing location and current device already has location, then

current device's location is deleted and set same as existing device's location.

- If not attaching existing then new location is created if no location exists for

current device, or existing one is updated if it is approximate(fuzzy).

- If current device already has a location previously, then it is deleted.

- If existing location is not attached, then a new location is created if no location exists for

current device, or existing one is updated if it is approximate(fuzzy).

Thanks! Based on the suggestions I have modified the doc string

openwisp_controller/config/settings.py

devkapilbansal · 2025-07-11T17:05:51Z

openwisp_controller/config/whois/service.py

+        if not self.is_valid_public_ip_address(new_ip):
+            return False
+
+        if not self.is_whois_enabled:
+            return False


I think based on our discussion we have decided to do cheap checks first. is_valid_public_ip_address will require an API call and should be done after checking if whois is enabled or not

Hi Kapil, is_valid_public_ip_address checks if ip address is public or not locally in memory without calling any API hence, it is kept first

We are importing ip_address in first line as well as using some variables with same name. Can we have a clear distinction between the two?
We can write the import line as
from ipaddress import ip_address as something

Yes, I am in favour of renaming the ip_address variable in get_device_whois_info method. I didn't found any other occurence for this.

devkapilbansal · 2025-07-11T17:13:41Z

openwisp_controller/geo/approximate_location/tasks.py

+    Creates/updates fuzzy location for a device based on the latitude and longitude
+    or attaches an existing location if `add_existing` is True.
+    Existing location here means a location of another device whose last_ip matches
+    the given ip_address.
+
+    When `add_existing` is True:
+    - If the current device has no location, attach the existing one; if it does,
+    update it with the existing one only if it is approximate (fuzzy).
+
+    When `add_existing` is False:
+    - A new location is created if no location exists for current device, or
+    existing one is updated using coords from WHOIS record if it is approximate(fuzzy).
+    """


👏 much better

devkapilbansal · 2025-07-11T17:15:58Z

...e_config/migrations/0009_organizationconfigsettings_approximate_location_enabled_and_more.py

+        migrations.AddField(
+            model_name="whoisinfo",
+            name="latitude",
+            field=models.FloatField(blank=True, help_text="Latitude", null=True),


Do we any validation checks in the code to ensure that latitude and longitude values are correct?

Makes sense, I will think of some tests for these as well

devkapilbansal · 2025-07-11T17:19:54Z

openwisp_controller/config/whois/utils.py

+            mocked_task.assert_not_called()
+        mocked_task.reset_mock()
+
+        with self.subTest(


Add one more check if it is not there, task not called via DeviceChecksumView when WHOIS is disabled

devkapilbansal · 2025-07-16T15:45:24Z

docs/user/approximate-location.rst

+    The **Approximate Location** feature is **disabled by default**.
+
+    Before enabling it, the :doc:`WHOIS Lookup feature <whois>` must be
+    enabled and then set


Suggested change

enabled and then set

enabled. Then set

devkapilbansal · 2025-07-16T15:53:07Z

docs/user/approximate-location.rst

+If **a matching location already exists** for another device with the same
+IP, the system will **attach that location** to the current device if:


Let's rewrite this, something like

Suggested change

If **a matching location already exists** for another device with the same

IP, the system will **attach that location** to the current device if:

The system will **attach the already existing matching location** of another device with same ip to the current device if **a matching location if

devkapilbansal · 2025-07-16T15:54:44Z

docs/user/approximate-location.rst

+If **a matching location already exists** for another device with the same
+IP, the system will **attach that location** to the current device if:
+
+- Only one device is found with that IP and it has a location.


What if more than one device has same ip?

If there are more than once devices having the same ip and location then notification will be sent to use as in that case we are not use which device's location to use. Will add this in docs as well

devkapilbansal · 2025-07-16T15:55:11Z

docs/user/approximate-location.rst

+- The current device **has no location** or if it does then the location
+  is **approximate**.


Suggested change

- The current device **has no location** or if it does then the location

is **approximate**.

- The current device **has no location** or that location

is **approximate**.

devkapilbansal · 2025-07-16T15:57:42Z

docs/user/approximate-location.rst

+If there is **no matching location**, a new approximate location is
+created or the existing one is updated using coordinates from the WHOIS
+record, but only if the existing location is approximate.


Suggested change

If there is **no matching location**, a new approximate location is

created or the existing one is updated using coordinates from the WHOIS

record, but only if the existing location is approximate.

If there is **no matching location** and existing location is approximate (if exists), a new approximate location is

created or the existing one is updated using coordinates from the WHOIS record.

Not sure about this as when there is no matching location then it will either create an approximate location else update the existing location only if the existing one is already approximate.
The suggested statement sounds a bit misleading.

devkapilbansal · 2025-07-16T16:10:44Z

openwisp_controller/geo/approximate_location/tasks.py

+        coords = Point(whois_obj.longitude, whois_obj.latitude, srid=4326)
+        address = whois_obj.formatted_address
+        location_name = (
+            ",".join(address.split(",")[:2]) + f" (Estimated: {ip_address})"


It should be similar with below name

Suggested change

",".join(address.split(",")[:2]) + f" (Estimated: {ip_address})"

",".join(address.split(",")[:2]) + f" (Estimated Location: {ip_address})"

devkapilbansal · 2025-07-16T16:13:52Z

openwisp_controller/geo/approximate_location/test_approximate_location.py

+
+        with self.subTest(
+            "Test Approximate Location field visible on admin when "
+            "WHOIS_CONFIGURED True"


Suggested change

"WHOIS_CONFIGURED True"

"WHOIS_CONFIGURED is True"

devkapilbansal · 2025-07-16T16:14:58Z

openwisp_controller/geo/approximate_location/test_approximate_location.py

+            importlib.reload(config_app_settings)
+            with self.subTest(
+                "Test Approximate Location field hidden on admin when "
+                "WHOIS_CONFIGURED False"


Suggested change

"WHOIS_CONFIGURED False"

"WHOIS_CONFIGURED is False"

devkapilbansal · 2025-07-16T16:16:32Z

openwisp_controller/geo/approximate_location/test_approximate_location.py

+        with self.subTest(
+            "Approximate location task called when last_ip has related WhoIsInfo"
+        ):


Not sure on this but if there is only one sub test, should we create sub tests?

There are other subtests called as well in statement above it

openwisp-controller/openwisp_controller/geo/approximate_location/test_approximate_location.py

Line 121 in fde52b0

self._task_called(

codesankalp · 2025-07-15T14:37:59Z

openwisp_controller/config/base/whois.py

@@ -51,6 +52,18 @@ class AbstractWHOISInfo(TimeStampedEditableModel):
        blank=True,
        help_text=_("CIDR"),
    )
+    latitude = models.FloatField(


Should we use PointField here?

Yes we can, I was also think of doing this as these are used for coordinates only

codesankalp · 2025-07-18T14:54:01Z

openwisp_controller/config/whois/service.py

+        if not self.is_valid_public_ip_address(new_ip):
+            return False
+
+        if not self.is_whois_enabled:
+            return False


Yes, I am in favour of renaming the ip_address variable in get_device_whois_info method. I didn't found any other occurence for this.

codesankalp · 2025-07-18T14:59:38Z

openwisp_controller/config/whois/test_whois.py

@@ -220,8 +220,41 @@ def test_whois_model_fields_validation(self):
        with self.assertRaises(ValidationError):
            self._create_whois_info(asn="InvalidASN")

+        # Common validation checks for latitude and longitude
+        latitudes = [


how about jus this?

cases = [ ("latitude", 100.0, "Ensure this value is less than or equal to 90.0."), ("latitude", -100.0, "Ensure this value is greater than or equal to -90.0."), ("longitude", 200.0, "Ensure this value is less than or equal to 180.0."), ("longitude", -200.0, "Ensure this value is greater than or equal to -180.0."), ] for field, value, expected_msg in cases: with self.subTest(field=field, value=value): with self.assertRaises(ValidationError) as cm: kwargs = {field: value} self._create_whois_info(**kwargs) self.assertEqual(cm.exception.message_dict[field][0], expected_msg)

codesankalp · 2025-07-18T15:02:11Z

openwisp_controller/config/whois/utils.py

@@ -1,3 +1,8 @@
+from unittest import mock


Let’s ensure we always keep test utilities separate from those used in functional code.

codesankalp · 2025-07-18T15:06:58Z

openwisp_controller/geo/estimated_location/tasks.py

+    logger.info(
+        f"Estimated location saved successfully for {device_pk} for IP: {ip_address}"
+    )


what if whois_obj doesn't exist, then it will log that as success which is incorrect. we should handle such cases as well.

codesankalp · 2025-07-18T15:12:20Z

openwisp_controller/geo/estimated_location/tasks.py

+        coords = Point(whois_obj.longitude, whois_obj.latitude, srid=4326)
+        address = whois_obj.formatted_address
+        location_name = (
+            ",".join(address.split(",")[:2]) + f" (Estimated Location: {ip_address})"
+            if address
+            else f"Estimated Location: {ip_address}"
+        )
+        # Used to update an existing location if it is estimated
+        # or create a new one if it doesn't exist
+        location_defaults = {
+            "name": location_name,
+            "type": "outdoor",
+            "organization_id": device.organization_id,
+            "is_mobile": False,
+            "geometry": coords,
+            "address": address,
+        }


let's define this as part of whois model class itself, so that it can be reused via model and have less dependency on this task.

codesankalp · 2025-07-18T15:15:20Z

openwisp_controller/geo/estimated_location/tasks.py

+    if add_existing and (not current_location or current_location.is_estimated):
+        existing_devices_location = (


this can be separated into a new function called: handle_attach_existing

codesankalp · 2025-07-18T15:16:26Z

openwisp_controller/geo/estimated_location/tasks.py

+        # If there are multiple devices with same last_ip then we need to inform
+        # the user to resolve the conflict manually.
+        if existing_devices_location.count() > 1:
+            send_whois_task_notification(


here logging an error will be better about multiple devices found

codesankalp · 2025-07-18T15:19:09Z

openwisp_controller/geo/estimated_location/tasks.py

+        if current_location and current_location.pk != existing_location.pk:
+            current_location.delete()


when we will get this case, can you explain a scenario to test it?

This was added due to an Issue I was facing while writing tests, which is now resolved. I will update this as i think there might be some changes in this.

codesankalp · 2025-07-18T15:20:01Z

openwisp_controller/geo/estimated_location/tasks.py

+            location = Location(**location_defaults, is_estimated=True)
+            location.full_clean()
+            location.save()
+            device_location.location = location
+            device_location.full_clean()
+            device_location.save()


we should use transaction.atomic here

devkapilbansal · 2025-07-22T14:51:39Z

openwisp_controller/config/base/whois.py

@@ -51,6 +52,24 @@ class AbstractWHOISInfo(TimeStampedEditableModel):
        blank=True,
        help_text=_("CIDR"),
    )
+    # latitude = models.FloatField(


Why this code is commented?

Sorry, might have been left during last changes. Will remove this

devkapilbansal · 2025-07-25T16:40:30Z

openwisp_controller/config/whois/service.py

+                    new_ip_address=new_ip,
+                )
+            )
+        # `add_existing` is `True` to handle the case when WHOIS already exists


Is this comment still relevant?

It is not, removing this

devkapilbansal · 2025-07-27T13:21:55Z

openwisp_controller/config/whois/service.py

+    def is_estimated_location_enabled(self):
+        """
+        Check if the Estimated location feature is enabled.
+        This does not require to set cache as `is_whois_enabled` already sets it


Do we have a test case for this?

I will update the existing test case which asserts cache.get to assert .set is not called as well

nemesifier · 2025-07-31T18:44:51Z

docs/user/whois.rst

+triggering the WHOIS lookup automatically.
+
+It accepts an optional flag ``--whois-related`` to exclude devices with
+WHOIS records.


This should be the default, I don't think we need the flag.

nemesifier · 2025-07-31T18:46:39Z

docs/user/whois.rst

@@ -45,6 +45,17 @@ met:
 - There is **no existing WHOIS record** for that IP.
 - WHOIS lookup is **enabled** for the device's organization.

+Handling Existing Devices


Instead of adding this section here, add it at the bottom of the setup instructions and provide a copy/paste example that includes enabling the virtualenv (for users using ansible-openwisp2).

Point 6 should be to restart the application if using ansible-openwisp2, while docker containers should just be respawned.

Point 7 should be to use the management command.

nemesifier · 2025-07-31T18:47:52Z

openwisp_controller/config/management/commands/clear_last_ip.py

+        devices = Device.objects.filter(_is_deactivated=False).exclude(last_ip=None)
+        devices = devices.only("last_ip")
+        if options["whois_related"]:
+            if not app_settings.WHOIS_CONFIGURED:


This check should be at the beginning of the command.

codesankalp

The feature is looking great. I did end-to-end testing. Please take a look at my comments below:

codesankalp · 2025-07-24T19:02:44Z

openwisp_controller/config/base/whois.py

+        if address:
+            parts = [part.strip() for part in address.split(",")[:2] if part.strip()]
+            location = ", ".join(parts)
+            return f"{location} (Estimated Location: {self.ip_address})"


should we keep Estimated Location translatable?

codesankalp · 2025-08-03T07:11:16Z

openwisp_controller/config/whois/service.py

+    def process_ip_data_and_location(self):
        """
-        Trigger WHOIS lookup based on the conditions of `_need_whois_lookup`.
-        Task is triggered on commit to ensure redundant data is not created.
+        Trigger WHOIS lookup based on the conditions of `_need_whois_lookup`
+        and also manage estimated locations based on the conditions of
+        `_need_estimated_location_management`.
+        Tasks are triggered on commit to ensure redundant data is not created.
        """
-        if self._need_whois_lookup(self.device.last_ip):
+        new_ip = self.device.last_ip
+        if self._need_whois_lookup(new_ip):
            transaction.on_commit(
                lambda: fetch_whois_details.delay(
                    device_pk=self.device.pk,
                    initial_ip_address=self.device._initial_last_ip,
-                    new_ip_address=self.device.last_ip,
+                    new_ip_address=new_ip,
+                )
+            )
+        # To handle the case when WHOIS already exists as in that case
+        # WHOIS lookup is not triggered but we still need to
+        # manage estimated locations.
+        elif self._need_estimated_location_management(new_ip):
+            transaction.on_commit(
+                lambda: manage_estimated_locations.delay(
+                    device_pk=self.device.pk, ip_address=new_ip


manage_estimated_locations keeps firing repeatedly, even when an estimated location already exists and the device’s IP hasn’t changed. can we ignore this task if ip and location is not changed?

Another thing which i found is delete handler is not working properly as shown in the demo below.

video: https://drive.google.com/file/d/1HbgtsxukFQbIPQuqlObTIqS7fLu6NiTh/view?usp=sharing

The first issue is fixed, had to remove the function from DeviceChecksumView.
I cannot replicate the second one as the record is getting deleted on device deletion

WHOIS_Deleted.mp4

then it might be issue with my system, @devkapilbansal can you please also verify this?

There is also a test for deletion of record on device delete, can you please check if that is failing as well?

Edit: last subtest of test_whois_creation

Sure, I will check this

@codesankalp @DragnEmperor How can we test the scenario where multiple devices have same last_ip? Any way to do it without router or VM?

I usually follow these steps:

Create 2 or more devices from admin

Use ngrok tunnel for creating a global link for the local server

Open either https://www.proxysite.com/ or https://proxyium.com/ and pass the url to checksum for the device. Selecting the same server will register same IP for the devices.

Last time while using using proxium, I believe the IPs were different for same server as well. Will try it once again or with proxysite

codesankalp · 2025-08-03T14:42:55Z

openwisp_controller/config/management/commands/clear_last_ip.py

+        if not app_settings.WHOIS_CONFIGURED:
+            self.stdout.write("WHOIS must be configured to use this option.")
+            return


i think we don't need this check, this management command is separate and doesn't need who is to be configured.

Closes #1034 Signed-off-by: DragnEmperor <dragnemperor@gmail.com>

Closes #1035 Signed-off-by: DragnEmperor <dragnemperor@gmail.com>

Closes #1036 Signed-off-by: DragnEmperor <dragnemperor@gmail.com>

Closes #1028 Signed-off-by: DragnEmperor <dragnemperor@gmail.com>

DragnEmperor changed the title ~~Issues/1034 fuzzy location creation~~ [feature] Fuzzy location creation Jun 12, 2025

DragnEmperor self-assigned this Jun 13, 2025

DragnEmperor added enhancement gsoc Part of a Google Summer of Code project labels Jun 13, 2025

DragnEmperor added this to [GSoC25] WHOIS Information and IP Address-Based Geolocation Jun 13, 2025

DragnEmperor moved this to In Progress in [GSoC25] WHOIS Information and IP Address-Based Geolocation Jun 13, 2025

DragnEmperor changed the base branch from gsoc25-whois to issues/1032-1033-whois-setup June 25, 2025 18:58

DragnEmperor force-pushed the issues/1034-fuzzy-location-creation branch 2 times, most recently from 6643b32 to 73c3b0a Compare June 30, 2025 08:16

Base automatically changed from issues/1032-1033-whois-setup to gsoc25-whois June 30, 2025 18:26

DragnEmperor force-pushed the issues/1034-fuzzy-location-creation branch from 73c3b0a to 44fa3e9 Compare July 1, 2025 13:42

devkapilbansal reviewed Jul 1, 2025

View reviewed changes

DragnEmperor marked this pull request as ready for review July 1, 2025 20:18

DragnEmperor moved this from In Progress to Needs Review in [GSoC25] WHOIS Information and IP Address-Based Geolocation Jul 2, 2025

codesankalp reviewed Jul 2, 2025

View reviewed changes

DragnEmperor force-pushed the gsoc25-whois branch from 41e0b55 to 3ffae10 Compare July 3, 2025 18:54

DragnEmperor force-pushed the issues/1034-fuzzy-location-creation branch from 563bb4a to f19ac51 Compare July 3, 2025 19:02

devkapilbansal reviewed Jul 8, 2025

View reviewed changes

devkapilbansal requested changes Jul 11, 2025

View reviewed changes

DragnEmperor force-pushed the issues/1034-fuzzy-location-creation branch 4 times, most recently from 9837a7f to fde52b0 Compare July 15, 2025 19:24

devkapilbansal requested changes Jul 16, 2025

View reviewed changes

DragnEmperor force-pushed the issues/1034-fuzzy-location-creation branch from 2d063af to fbd5bb7 Compare July 16, 2025 18:48

DragnEmperor mentioned this pull request Jul 17, 2025

[chores] Added image for Estimated location feature #1089

Merged

2 tasks

codesankalp requested changes Jul 18, 2025

View reviewed changes

devkapilbansal reviewed Jul 22, 2025

View reviewed changes

DragnEmperor force-pushed the issues/1034-fuzzy-location-creation branch from b82ff48 to 641a3d9 Compare July 22, 2025 20:22

devkapilbansal reviewed Jul 27, 2025

View reviewed changes

nemesifier requested changes Jul 31, 2025

View reviewed changes

DragnEmperor force-pushed the issues/1034-fuzzy-location-creation branch from 2dad1f0 to 48d0036 Compare August 1, 2025 05:36

codesankalp requested changes Aug 3, 2025

View reviewed changes

DragnEmperor force-pushed the gsoc25-whois branch from 7e941ae to 5c93b19 Compare August 21, 2025 13:47

DragnEmperor force-pushed the issues/1034-fuzzy-location-creation branch from a9c5fbc to bc837a1 Compare August 21, 2025 16:52

DragnEmperor changed the title ~~[feature] Fuzzy location creation~~ [feature] Estimated location creation Aug 28, 2025

DragnEmperor force-pushed the issues/1034-fuzzy-location-creation branch from d10ef51 to 0a1c1cc Compare August 29, 2025 04:08

DragnEmperor and others added 4 commits August 29, 2025 10:26

[feature] Estimated location: Setup and Management #1034

d7a2198

Closes #1034 Signed-off-by: DragnEmperor <dragnemperor@gmail.com>

[feature] Estimated location: added notification and admin warning #1035

0b389a6

Closes #1035 Signed-off-by: DragnEmperor <dragnemperor@gmail.com>

[feature] Set location estimated flag to False on manual update #1036

01c318a

Closes #1036 Signed-off-by: DragnEmperor <dragnemperor@gmail.com>

[feature] Estimated Location: Admin and API filters #1028

2c1dda6

Closes #1028 Signed-off-by: DragnEmperor <dragnemperor@gmail.com>

DragnEmperor force-pushed the issues/1034-fuzzy-location-creation branch from 0a1c1cc to 2c1dda6 Compare August 29, 2025 04:57

		If a matching location already exists for another device with the same
		IP, the system will attach that location to the current device if:

	If a matching location already exists for another device with the same
	IP, the system will attach that location to the current device if:
	The system will attach the already existing matching location of another device with same ip to the current device if **a matching location if

		- The current device has no location or if it does then the location
		is approximate.

	",".join(address.split(",")[:2]) + f" (Estimated: {ip_address})"
	",".join(address.split(",")[:2]) + f" (Estimated Location: {ip_address})"

		if add_existing and (not current_location or current_location.is_estimated):
		existing_devices_location = (

		if current_location and current_location.pk != existing_location.pk:
		current_location.delete()

Uh oh!

[feature] Estimated location creation #1067

Are you sure you want to change the base?

[feature] Estimated location creation #1067

Uh oh!

Conversation

DragnEmperor commented Jun 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Reference to Existing Issue

Description of Changes

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

coveralls commented Jul 1, 2025

Uh oh!

codesankalp left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

DragnEmperor commented Jul 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

devkapilbansal left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

DragnEmperor commented Jun 12, 2025 •

edited

Loading

DragnEmperor commented Jul 3, 2025 •

edited

Loading