Skip to content

Convert NOTE to lowercase for stderr messages #5838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 1, 2025
Merged

Convert NOTE to lowercase for stderr messages #5838

merged 1 commit into from
Sep 1, 2025
+3 −3

Conversation

gartikis
Copy link
Contributor

@gartikis gartikis commented Sep 1, 2025

@solardiz mentioned in this PR:

Actually, it is "Note" in many other messages, and "NOTE" in only 3 other messages (but one of them is in zip2john). So we may want to get the rest of them changed to "Note".

So this PR changes the other 3 instances where NOTE is seen in all caps to lowercase for stderr messages.

magnumripper
magnumripper approved these changes Sep 1, 2025
View reviewed changes
Copy link
Member

@magnumripper magnumripper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@solardiz solardiz merged commit 1dfb3e7 into openwall:bleeding-jumbo Sep 1, 2025
32 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magnumripper magnumripper magnumripper approved these changes

@solardiz solardiz solardiz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gartikis @magnumripper @solardiz