You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HistogramAggregator incorrectly assumes positive-only values, and therefore produces wrong max values on export when only negative values are provided (e.g. when ExplicitBucketHistogramAggregation is used with UpDownCounter via View configuration).
This PR fixes this by replacing the default max with -Infinity
Bug fix (non-breaking change which fixes an issue)
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Merging #3086 (28d8c56) into main (747c404) will decrease coverage by 0.41%.
The diff coverage is 100.00%.
❗ Current head 28d8c56 differs from pull request most recent head fc430be. Consider uploading reports for the commit fc430be to get more accurate results
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update. I think at one point the spec had positive only values so this is likely a remnant of that? Not sure. In any case it is a good change.
Thanks for the update. I think at one point the spec had positive only values so this is likely a remnant of that? Not sure. In any case it is a good change.
When I recently implemented this feature in #3032, I was not thinking of Histogram Aggregations in combination with UpDownCounter and ObservableGauge, which allow negative values. 😓 For Histogram instruments, we check if all values are non-negative (as per the spec). I did not consider that the aggregation might be used by non-histograms, and that the values provided there can be < -1.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
HistogramAggregatorincorrectly assumes positive-only values, and therefore produces wrongmaxvalues on export when only negative values are provided (e.g. whenExplicitBucketHistogramAggregationis used withUpDownCounterviaViewconfiguration).This PR fixes this by replacing the default
maxwith-InfinityFixes #3085
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: