Downgrade otel-go #13429
Merged
Downgrade otel-go #13429
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codeboten
reviewed
Jul 18, 2025
songy23
reviewed
Jul 18, 2025
changelog added |
songy23
approved these changes
Jul 18, 2025
Co-authored-by: Yang Song <songy23@users.noreply.github.com>
codeboten
approved these changes
Jul 18, 2025
…rter (open-telemetry#13344)" This reverts commit f847043.
dmathieu
approved these changes
Jul 18, 2025
songy23
reviewed
Jul 18, 2025
songy23
approved these changes
Jul 18, 2025
Co-authored-by: Yang Song <songy23@users.noreply.github.com>
|
Thanks for the wordsmithing @songy23 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/v0.130.x #13429 +/- ##
====================================================
- Coverage 91.53% 91.52% -0.02%
====================================================
Files 528 528
Lines 29469 29471 +2
====================================================
- Hits 26974 26972 -2
- Misses 1969 1972 +3
- Partials 526 527 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
d82267d
into
open-telemetry:release/v0.130.x
34 checks passed
bogdandrutu
pushed a commit
that referenced
this pull request
Jul 21, 2025
Reverts #13429 so that we can bump to the to-be-released bugfix version that adds open-telemetry/opentelemetry-go/pull/7044
mx-psi
added a commit
that referenced
this pull request
Jul 22, 2025
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Prepares release v0.130.1/v1.36.1 to release #13429 <!-- Issue number if applicable --> #### Link to tracking issue Updates #13381 Relates to open-telemetry/opentelemetry-go/issues/7039 --------- Co-authored-by: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com>
songy23
added a commit
to songy23/opentelemetry-service
that referenced
this pull request
Jul 23, 2025
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> Downgrades opentelemetry-go dependencies effectively reverting open-telemetry#13289 and others - Due to a [bug](open-telemetry/opentelemetry-go#7039) in the prometheus exporter, if you are configuring a prometheus exporter, the collector's internal metrics will be emitted with an unexpected suffix in its name. For example, the metric `otelcol_exporter_sent_spans__spans__total` instead of `otelcol_exporter_sent_spans_total`. The workaround is to manually configure `without_units: true` in your prometheus exporter config ```yaml service: telemetry: metrics: readers: - pull: exporter: prometheus: host: 0.0.0.0 port: 8888 without_units: true ``` If you are using the collector's default Prometheus exporter for exporting internal metrics you are unaffected. --------- Signed-off-by: alex boten <223565+codeboten@users.noreply.github.com> Co-authored-by: alex boten <223565+codeboten@users.noreply.github.com> Co-authored-by: Yang Song <songy23@users.noreply.github.com>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 23, 2025
cherry-pick of d82267d `go.opentelemetry.io/otel/exporters/prometheus v0.59.1` does not fully fix the metric name issue so we have to revert to v0.58.0 Downgrades opentelemetry-go dependencies effectively reverting #13289 and others - Due to a [bug](open-telemetry/opentelemetry-go#7039) in the prometheus exporter, if you are configuring a prometheus exporter, the collector's internal metrics will be emitted with an unexpected suffix in its name. For example, the metric `otelcol_exporter_sent_spans__spans__total` instead of `otelcol_exporter_sent_spans_total`. The workaround is to manually configure `without_units: true` in your prometheus exporter config ```yaml service: telemetry: metrics: readers: - pull: exporter: prometheus: host: 0.0.0.0 port: 8888 without_units: true ``` If you are using the collector's default Prometheus exporter for exporting internal metrics you are unaffected. Signed-off-by: alex boten <223565+codeboten@users.noreply.github.com> Co-authored-by: Pablo Baeyens <pablo.baeyens@datadoghq.com> Co-authored-by: alex boten <223565+codeboten@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Downgrades opentelemetry-go dependencies effectively reverting #13289 and others
❗ Known Issues ❗
Due to a bug in the prometheus exporter, if you are configuring a prometheus exporter, the collector's internal metrics will be emitted with an unexpected suffix in its name. For example, the metric
otelcol_exporter_sent_spans__spans__totalinstead ofotelcol_exporter_sent_spans_total. The workaround is to manually configurewithout_units: truein your prometheus exporter configIf you are using the collector's default Prometheus exporter for exporting internal metrics you are unaffected.