Skip to content

Fix metrics split logic to consider metrics description into the size #13418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 18, 2025
Merged

Fix metrics split logic to consider metrics description into the size #13418

merged 1 commit into from
Jul 18, 2025

Conversation

bogdandrutu
Copy link
Member

No description provided.

@bogdandrutu bogdandrutu requested review from dmitryax and a team as code owners July 18, 2025 03:23
@bogdandrutu bogdandrutu force-pushed the metrics-tests branch 2 times, most recently from 89fa4cd to 813bf9b Compare July 18, 2025 03:25
@bogdandrutu bogdandrutu enabled auto-merge July 18, 2025 03:26
@codecov Codecov
Copy link

codecov bot commented Jul 18, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.44%. Comparing base (2b2f6f0) to head (376f4e1).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #13418      +/-   ##
==========================================
- Coverage   91.51%   91.44%   -0.08%     
==========================================
  Files         528      528              
  Lines       29527    29536       +9     
==========================================
- Hits        27023    27008      -15     
- Misses       1976     1995      +19     
- Partials      528      533       +5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bogdandrutu
Fix metrics split logic to consider metrics description into the size
376f4e1 
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
@bogdandrutu bogdandrutu mentioned this pull request Jul 18, 2025
Merged
@bogdandrutu bogdandrutu added this pull request to the merge queue Jul 18, 2025
Merged via the queue into open-telemetry:main with commit d435dbe Jul 18, 2025
56 checks passed
@bogdandrutu bogdandrutu deleted the metrics-tests branch July 18, 2025 14:36
github-merge-queue bot pushed a commit that referenced this pull request Jul 18, 2025
@bogdandrutu
[chore] Fix the fix of OOM when size of one item larger than max size (…
6f49591 
…#13419)

No changelog because if fixes logic added in current release.

Depends on
#13418

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmitryax dmitryax dmitryax approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bogdandrutu @dmitryax