v5.0.x: fortran: fix ompi string c2f where len(fstr) < len(cstr) #13382
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks to Ben Menadue for pointing out that ompi_fortran_string_c2f() missed a case to properly terminate the resulting Fortran string when copying from a longer C source string. Signed-off-by: Jeff Squyres <jeff@squyres.com> (cherry picked from commit 694e78a)
|
oops what's going on with jenkins CI ompi:bot:retest |
|
bot:ompi:retest |
hppritcha
previously approved these changes
Aug 26, 2025
|
Added 2nd commit from main PR #13387. |
hppritcha
approved these changes
Aug 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to Ben Menadue @benmenadue for pointing out that ompi_fortran_string_c2f() missed a case to properly terminate the resulting Fortran string when copying from a longer C source string.
(cherry picked from commit 694e78a)
This is the v5.0.x PR corresponding to main PR #13381 and #13387
Fixes #13375