Qualify what GC statistics are printed with v=0x400 #14191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Discussed at today's triage meeting. Instead of documenting the current behaviour, we should fix the code so that GC stats for the whole program are printed at program exit. |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the documentation for this runtime option says "Output GC statistics at program exit." which might be interpreted as covering GC statistics for a multi-domain program. At least that's how I read it. Looking at the implementation in
caml_do_exitit accesses caml_domain_state so is more accurately described as printing the initial domain's GC stats.The code in question https://github.com/ocaml/ocaml/blob/trunk/runtime/sys.c#L135-L181
This documentation update applies since OCaml 5.0. Probably doesn't need an entry in Changes.