Skip to content

Conversation

tytan652
Copy link
Collaborator

@tytan652 tytan652 commented Aug 30, 2025

Description

  • Linux has backports to fix stack smash and TLS issues
  • macOS has memory allocator changes structure changes to work with Xcode 26

Motivation and Context

Those re-builds are meant for OBS 32.0

How Has This Been Tested?

CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

@gxalpha
Copy link
Member

gxalpha commented Aug 30, 2025

Note: Afaik, v5 on macOS does not have memory allocator changes compared to v4 (and isn’t even a rebuild), it simply changes the framework structure to work with Xcode 26.

@tytan652
Copy link
Collaborator Author

Note: Afaik, v5 on macOS does not have memory allocator changes compared to v4 (and isn’t even a rebuild), it simply changes the framework structure to work with Xcode 26.

I can change the commit name if needed, I thought that v5 had malloc related changes.

- Linux has backports to fix stack smash and TLS issues
- macOS has structure changes to work with Xcode 26
Copy link
Member

@PatTheMav PatTheMav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR and commit description are correct now, though I wonder if I shouldn't just pull the ripcord and build an actual v5 with the allocator change included and the structural changes, as we are in no rush to bring this in to OBS 32 (the structural changes are just needed to have a working master branch once macOS 26 releases).

@PatTheMav
Copy link
Member

The PR and commit description are correct now, though I wonder if I shouldn't just pull the ripcord and build an actual v5 with the allocator change included and the structural changes, as we are in no rush to bring this in to OBS 32 (the structural changes are just needed to have a working master branch once macOS 26 releases).

I've tried and it doesn't build with a fully disabled allocator shim, so it's probably good enough to keep v5 for its structural changes.

@RytoEX
Copy link
Member

RytoEX commented Sep 2, 2025

The PR and commit description are correct now, though I wonder if I shouldn't just pull the ripcord and build an actual v5 with the allocator change included and the structural changes, as we are in no rush to bring this in to OBS 32 (the structural changes are just needed to have a working master branch once macOS 26 releases).

For my part, I mostly want people to be able to build OBS Studio 32.0.x in Xcode 26 and on/for macOS 26.

@RytoEX RytoEX requested a review from PatTheMav September 4, 2025 18:12
@RytoEX RytoEX self-assigned this Sep 4, 2025
@RytoEX RytoEX added this to the OBS Studio 32.0 milestone Sep 4, 2025
@RytoEX RytoEX added the Bug Fix Non-breaking change which fixes an issue label Sep 4, 2025
@RytoEX RytoEX merged commit 480f514 into obsproject:master Sep 4, 2025
15 checks passed
@tytan652 tytan652 deleted the cef_update branch September 5, 2025 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Fix Non-breaking change which fixes an issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants