Skip to content

crypto: fix subtle.getPublicKey error for secret type key inputs #59558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 22, 2025
Merged

crypto: fix subtle.getPublicKey error for secret type key inputs #59558

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/internal/crypto/webcrypto.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1090,7 +1090,8 @@ async function getPublicKey(key, keyUsages) {
});

if (key[kKeyType] !== 'private')
throw lazyDOMException('key must be a private key', 'InvalidAccessError');
throw lazyDOMException('key must be a private key',
key[kKeyType] === 'secret' ? 'NotSupportedError' : 'InvalidAccessError');

const keyObject = createPublicKey(key[kKeyObject]);

Expand Down
7 changes: 6 additions & 1 deletion test/parallel/test-webcrypto-get-public-key.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,11 +41,16 @@ for await (const { privateKey } of [
name: 'SyntaxError',
message: /Unsupported key usage/
});

await assert.rejects(() => subtle.getPublicKey(publicKey, publicKey.usages), {
name: 'InvalidAccessError',
message: 'key must be a private key'
});
}

const secretKey = await subtle.generateKey(
{ name: 'AES-CBC', length: 128 }, true, ['encrypt', 'decrypt']);
await assert.rejects(() => subtle.getPublicKey(secretKey, ['encrypt', 'decrypt']), {
name: 'InvalidAccessError',
name: 'NotSupportedError',
message: 'key must be a private key'
});
Loading