Skip to content

tools: avoid parsing test files twice #59526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 20, 2025
+5 −0
Merged

tools: avoid parsing test files twice #59526

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1ba5b7e
tools: avoid parsing test files twice
pmarchini Aug 18, 2025
c59f984
fixup! tools: avoid parsing test files twice
pmarchini Aug 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions tools/test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -788,6 +788,11 @@ def Execute(args, context, timeout=None, env=None, disable_core_files=False,
for key, value in env.items():
env_copy[key] = value

# We append NODE_SKIP_FLAG_CHECK (ref: test/common/index.js)
# to avoid parsing the test files twice when looking for
# flags or environment variables defined via // Flags: and // Env:
env_copy["NODE_SKIP_FLAG_CHECK"] = "true"

preexec_fn = None

def disableCoreFiles():
Expand Down
Loading