Skip to content

[Edge] Add custom property #4700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Edge] Add custom property #4700

wants to merge 1 commit into from

Conversation

gichan-jang
Copy link
Member

Add custom property for edgesrc/edgesink.
, separated options(key:value) are set on the edge handle.

Self evaluation:

  1. Build test: []Passed [ ]Failed []Skipped
  2. Run test: []Passed [ ]Failed []Skipped

@gichan-jang
[Edge] Add custom property
9f3b472 
Add custom property for edgesrc/edgesink.
, separated options are set on the edge handle.

Signed-off-by: Gichan Jang <gichan2.jang@samsung.com>
myungjoo
myungjoo approved these changes Mar 14, 2025
View reviewed changes
Copy link
Member

@myungjoo myungjoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Add a usage example of the custom property on the boilerplate.
E.g.,:

nnstreamer/gst/join/gstjoin.c

Lines 13 to 30 in 3ba5b6c

/**
* SECTION:element-join
* @see_also #GstInputSelector
* @note A join has reduced and changed input-selector's function.
*
* Connect recently arrived buffer from N input streams to the output pad.
* N streams should not operate at the same time.
* All capabilities (input stream i and output stream) should be the same.
* For example, If one sinkpad is receiving buffer, the others should be stopped.
* <refsect2>
* <title>Example launch line</title>
* gst-launch-1.0 ... (input stream 0) ! join.sink_0 \
* ... (input stream 1) ! join.sink_1 \
* ... \
... (input stream N) ! join.sink_n \
join name=join ! (arrived input stream) ...
* </refsect2>
*/

myungjoo
myungjoo reviewed Mar 14, 2025
View reviewed changes
gst/edge/edge_sink.c
nns_loge ("Failed to connect to edge device!");
return FALSE;
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a bugfix, unrelated with this topic?

myungjoo
myungjoo requested changes Mar 14, 2025
View reviewed changes
Copy link
Member

@myungjoo myungjoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regression with edge-connection. (unittest fail due to this change)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@myungjoo myungjoo myungjoo requested changes

@jijoongmoon jijoongmoon Awaiting requested review from jijoongmoon jijoongmoon is a code owner

@again4you again4you Awaiting requested review from again4you again4you is a code owner

@jaeyun-jung jaeyun-jung Awaiting requested review from jaeyun-jung jaeyun-jung is a code owner

@wooksong wooksong Awaiting requested review from wooksong wooksong is a code owner

@anyj0527 anyj0527 Awaiting requested review from anyj0527 anyj0527 is a code owner

@songgot songgot Awaiting requested review from songgot songgot is a code owner

@jihochu jihochu Awaiting requested review from jihochu jihochu is a code owner

@niley7464 niley7464 Awaiting requested review from niley7464 niley7464 is a code owner

@yeonykim2 yeonykim2 Awaiting requested review from yeonykim2 yeonykim2 is a code owner

@14KGun 14KGun Awaiting requested review from 14KGun 14KGun is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gichan-jang @myungjoo