-
Notifications
You must be signed in to change notification settings - Fork 204
feat(user): add primary_guild #1259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ooliver1
wants to merge
18
commits into
master
Choose a base branch
from
ooliver1/feat/guild-tags
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blord0
reviewed
Jun 25, 2025
blord0
reviewed
Jun 25, 2025
blord0
reviewed
Jun 25, 2025
self._state, guild_id=self.identity_guild_id, badge_hash=self._badge | ||
) | ||
return None | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can get the creation date of the primary guild
Suggested change
@property | |
def created_at(self) -> Optional[datetime]: | |
"""Optional[:class:`datetime.datetime`]: Returns the primary guild's creation time in UTC.""" | |
if self.identity_guild_id: | |
return snowflake_time(self.identity_guild_id) | |
return None | |
blord0
reviewed
Jun 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
p: high
Priority: high - should be worked on as soon as reasonable
s: awaiting review
Status: the issue or PR is awaiting reviews
t: api coverage
Type: api coverage - this adds code to cover the discord API
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a non-None
primary_guild
property representing a user's "tag" as described in discord/discord-api-docs#6836.When enabled is
None
, this is described in messages in the Discord Developers server as meaning the tag has been edited but not approved by the user. This hopefully will be mentioned in the Discord documentation when it is merged 🤞.Forgive the
member.py
scope creep with avatar decoration data, spotted this needing to be edited too (could member cache updating be handled better?).Test Code
This is a Code Change
task pyright
and fixed the relevant issues.