Skip to content
This repository was archived by the owner on Jun 3, 2025. It is now read-only.

Conversation

rahul-tuli
Copy link
Member

Add note for running torch tests

@rahul-tuli rahul-tuli requested review from bfineran and dsikka June 9, 2023 15:27
@rahul-tuli rahul-tuli self-assigned this Jun 9, 2023
dsikka
dsikka previously approved these changes Jun 9, 2023
@rahul-tuli rahul-tuli added the documentation Improvements or additions to documentation label Jun 9, 2023
DEVELOPING.md Outdated
@@ -40,6 +40,9 @@ Those can be installed by adding the framework name to the install extras. Frame
python3 -m pip install -e "./[dev,torch]"
```

Note: Running all pytorch tests using `make test TARGETS=torch`, also requires `torchvision`
and `onnxruntime` install all these dependencies using `python3 -m pip install "./[dev, torch, torchvision, onnxruntime]"`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing -e?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oooh Good catch Ben!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated!

@bfineran bfineran merged commit 24471da into main Jun 9, 2023
@bfineran bfineran deleted the update-developing-readme branch June 9, 2023 22:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants