Add System.shell command injection #175
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @realcorvus - sorry for the delay on this; for reasons explained in another issue (#180), I've created an official fork and as such you're welcome to bring this PR over there to make sure you get the proper attribution or I can just fold it over myself - either way! Feel free to close out this PR and follow progress over in the new repo here from now on! For what it's worth the hex package won't change since I can just cut over to pointing to the new repo. |
houllette
added a commit
to sobelow/sobelow
that referenced
this pull request
May 9, 2025
…mand injection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
System.shellwas added in Elixir 1.12 - https://hexdocs.pm/elixir/1.18.1/System.html#shell/2This PR modifies the existing
System.cmdcheck to addshell. Tested on Potion Shop - https://github.com/securityelixir/potion_shop with the following change:CI.System: Command Injection via `System` function - lib/carafe_web/controllers/potion_controller.ex:19