Reland #2873 - Disable the unused and problematic tools #3150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Disable the unused and problematic tools The Go modules are all far out of date and some tooling is reporting the repo as having security issues. We do not use any part of Go, EMSDK or perfetto in the SkiaSharp project. In an ideal world we don't have to make changes and there is a special flag that exists for us to "disable all issues", but that does not exist and trying to make that flag work only on CI is unnecessary. We can just delete the few places that are having issues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
The Go modules are all far out of date and some tooling is reporting the repo as having security issues. We do not use any part of Go, EMSDK or perfetto in the SkiaSharp project.
In an ideal world we don't have to make changes and there is a special flag that exists for us to "disable all issues", but that does not exist and trying to make that flag work only on CI is unnecessary. We can just delete the few places that are having issues.
This was originally merged as part of #2873 but I lost the changes when updating to 118. None of this code made it into the library as can be seen by the fact it still works when I just simply remove whole chunks.