[max] Refactor Value.from_mlir to use a self-registering factory #5257
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the
Value.from_mlir
class method inmax/graph/value.py
. The previous implementation relied on a growingif/isinstance
chain, which has been replaced with a robust, self-registering factory pattern.Changes Made
__init_subclass__
to act as a self-registering factory.Value[mo.TensorType]
) to infer the associated MLIR type.Benefits of this Change
This refactoring improves the software design in several key areas:
Value
base class is now fully decoupled from its concrete subclasses. It no longer needs explicit knowledge of them.Value
types can be added without any changes to the base class, significantly improving maintainability and extensibility.