[stdlib][refactor] Remove UnsafePointer.offset method #5180
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es for clarity and consistency
…ules for consistency
…odules for consistency
…r_dynamic_stride, and test_partial_load_store modules for consistency
…epointer modules for consistency
|
All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
- Replace .offset() with + operator in int_tuple.mojo memcpy calls - Replace .offset() with + operator in layout_tensor.mojo load/store operations - Replace .offset() with + operator in bench_elementwise.mojo strided_load calls These changes address the CI compilation errors after removing the offset method.
c4a6988 to
6d8a93e
Compare
- Replace all .offset() method calls with + operator across entire max/kernels directory - Apply systematic sed replacements to convert pointer arithmetic patterns - Handle various pointer variable names: ptr, data, src_ptr, dst_ptr, etc. - Fix patterns in source files, test files, and benchmark files - This completes comprehensive removal of deprecated .offset() method usage
- Fix patterns like 'ptr + (expr).load[' to '(ptr + expr).load[' - Fix patterns like 'ptr + (expr).store[' to '(ptr + expr).store[' - Correct broken pointer arithmetic expressions in: * _multistage_gemm_gpu.mojo * dual_gemm.mojo * matmul_amd.mojo * matmul_i8mm.mojo * matmul_vnni.mojo * conv.mojo * qmatmul.mojo * qmatmul_gpu.mojo * test files - Ensure proper precedence for pointer arithmetic operations - Fixes compilation errors: 'Int' value has no attribute 'load/store/bitcast'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[stdlib][refactor] Remove UnsafePointer.offset method
This PR removes the deprecated
UnsafePointer.offset()method from the Mojo standard library and replaces all usages with pointer arithmetic (ptr + n) or direct dereferencing (ptr[n]), as appropriate.Key changes:
UnsafePointer.offset()from the stdlib..offset()with+operator or[]indexing.Closes #5175.