Skip to content

fix: In emoji-mart-react, fix /issues/812 TypeError: Illegal constructor. #975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: In emoji-mart-react, fix /issues/812 TypeError: Illegal constructor. #975

wants to merge 1 commit into from

Conversation

kmashint
Copy link

This fixes the below issue while still returning the cleanup function from useEffect().
#812

This prior fix attempt returned early and didn't always allow for the cleanup function from useEffect().
#958

@kmashint kmashint mentioned this pull request Jan 24, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@dmkato dmkato dmkato approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kmashint @dmkato