fix: changed the node js version for devcontainer #257400
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deepak1556
approved these changes
Jul 23, 2025
aiday-mar
approved these changes
Jul 23, 2025
|
Thank you for the approvals , it feels great to see my first contribution to VS code merged. I have using this tool for 5 years now and contributing to it , no matter how small it is feels amazing |
|
@Rishi-infy47 you seem to have closed the PR before it got merged. |
|
@deepak1556 got over excited , i am sorry and thank you |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per #257193 the dev containers were having issues with node js version 20. I have updated the DockerFile to allow it for v22 as well.
Old :
New: