Skip to content

fix: memory leak in ChatInputPart #257082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 24, 2025
Merged

fix: memory leak in ChatInputPart #257082

merged 1 commit into from
Jul 24, 2025

Conversation

SimonSiefke
Copy link
Contributor

Registers the _contextResourceLabels disposable to dispose it when chatInputPart is disposed.

@amunger amunger requested a review from roblourens July 21, 2025 16:30
@vs-code-engineering vs-code-engineering bot added this to the July 2025 milestone Jul 21, 2025
roblourens
roblourens approved these changes Jul 24, 2025
View reviewed changes
Copy link
Member

@roblourens roblourens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@deepak1556 deepak1556 enabled auto-merge (squash) July 24, 2025 22:23
@deepak1556 deepak1556 merged commit e50b55c into microsoft:main Jul 24, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roblourens roblourens roblourens approved these changes

@amunger amunger amunger approved these changes

Assignees

@amunger amunger

Labels
triage-needed
Projects
None yet
Milestone
July 2025
Development

Successfully merging this pull request may close these issues.
4 participants
@SimonSiefke @roblourens @amunger @deepak1556