Skip to content

Conversation

bytemain
Copy link
Contributor

@bytemain bytemain commented Jul 16, 2025

The commit introduces a new interface ITerminalLaunchResult to replace the previously used inline return type { injectedArgs: string[] } in various terminal process-related methods.

When I want to add an attribute to the return type of start, I found that I have changed many files, so I want to add this pr first.

@bytemain bytemain changed the title refactor(terminal): introduce IProcessCreationResult interface refactor(terminal): introduce IProcessCreateResult interface Jul 16, 2025
@bytemain bytemain changed the title refactor(terminal): introduce IProcessCreateResult interface refactor(terminal): introduce ITerminalLaunchResult interface Jul 16, 2025
Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bytemain I'm curious what you needed to add?

@Tyriar Tyriar added this to the July 2025 milestone Jul 16, 2025
@bytemain
Copy link
Contributor Author

@bytemain I'm curious what you needed to add?

need to know whether the shellIntegrationEnvironmentReporting is enabled for this terminal, because the logic at the node process will ultimately affect whether this feature is enabled, I need to obtain at the browser process whether the env reporting is finally enabled, so I modified the return type to { injectedArgs: string[], injectedEnv: Record<string, string> }.

CleanShot 2025-07-17 at 10 47 44@2x

But I think the code I mentioned above will not contribute to the VSCode repository.

@Tyriar
Copy link
Member

Tyriar commented Jul 17, 2025

Interesting. Note that the feature there is very much experimental and is likely to be tweaked. You probably don't want to depend upon it until the API is finalized tbh.

Tyriar
Tyriar previously approved these changes Jul 17, 2025
@Tyriar Tyriar enabled auto-merge July 17, 2025 14:31
amunger
amunger previously approved these changes Jul 17, 2025
@Tyriar Tyriar dismissed stale reviews from amunger and themself via 7f9ab3d July 17, 2025 17:24
@rzhao271 rzhao271 requested review from Tyriar and amunger July 17, 2025 18:09
@Tyriar Tyriar merged commit d327f0b into microsoft:main Jul 17, 2025
17 checks passed
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Aug 31, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants