Add commit_id option to ServeWebArgs for specific client version #255494
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@microsoft-github-policy-service agree company="Two Sigma" |
|
This will still auto update to the latest commit after a period of time |
Good point, running the update checker is rather pointless if a commit SHA was passed in. I think this would've short-circuited to the commit SHA if passed, but better off not spawning the checker anyways - let me know if you had a different issue in mind that I've missed :) |
connor4312
approved these changes
Jul 14, 2025
|
thanks! |
dbaeumer
approved these changes
Jul 14, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #255218
I opened that issue and it hasn't received its requisite 20 community upvotes, but it seems like a lightweight change. This is intended to avoid scenarios where
code serve-webis unusable due to problems with the latest release client.