Skip to content

Fix popup message when hovering over an instruction breakpoint #254925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 10, 2025
Merged

Fix popup message when hovering over an instruction breakpoint #254925

merged 2 commits into from
Jul 10, 2025

Conversation

Schpoone
Copy link
Contributor

@Schpoone Schpoone commented Jul 9, 2025

Testing steps:

  1. Set an instruction breakpoint through the disassembly view
  2. Hover over the address text of the breakpoint in the breakpoints view
  3. Observe that the popup no longer says "Decimal address: breakpoint.address.toString()"

connor4312
connor4312 reviewed Jul 9, 2025
View reviewed changes
@Schpoone @connor4312
Update src/vs/workbench/contrib/debug/browser/breakpointsView.ts
9cb8ead 
Co-authored-by: Connor Peet <connor@peet.io>
@vs-code-engineering vs-code-engineering bot added this to the July 2025 milestone Jul 10, 2025
@connor4312 connor4312 enabled auto-merge (squash) July 10, 2025 04:30
@connor4312 connor4312 merged commit af0a171 into microsoft:main Jul 10, 2025
17 of 18 checks passed
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Aug 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bpasero bpasero bpasero approved these changes

@connor4312 connor4312 connor4312 approved these changes

Assignees

@connor4312 connor4312

Labels
triage-needed
Projects
None yet
Milestone
July 2025
Development

Successfully merging this pull request may close these issues.
4 participants
@Schpoone @bpasero @connor4312 @DonJayamanne