Add Mica Alt support to Microsoft Terminal (#17650) #19246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

deepanshu-maliyan wants to merge 2 commits into microsoft:main from deepanshu-maliyan:copilot/fix-86f3f6b9-3430-4e87-832b-22bf77fb058c

deepanshu-maliyan commented Aug 15, 2025

This pull request adds support for the Mica Alt theme in Windows Terminal as requested in #17650.

The useMica setting now accepts both boolean (true/false) and string enums ("mica", "micaAlt", "none"), following the pattern of bellStyle.
C++ logic and settings parsing are updated to allow both the existing and new values.
Associated schema, interface, and test changes are included for compatibility.

Fixes #17650

Thank you for your time and review.

Copilot AI and others added 2 commits

August 15, 2025 15:29


          Initial plan

5a7baeb


          Add MicaKind enum support to replace boolean useMica setting

69f340b

Co-authored-by: deepanshu-maliyan <115917329+deepanshu-maliyan@users.noreply.github.com>

Author

deepanshu-maliyan commented Aug 15, 2025

@microsoft-github-policy-service agree

github-advanced-security bot found potential problems

View reviewed changes

src/cascadia/WindowsTerminal/IslandWindow.cpp

+              #include <TerminalThemeHelpers.h>
+              #include <CoreWindow.h>
+              // Define DWMSBT_TRANSIENTWINDOW if not available (for Mica Alt)

Check failure

Code scanning / check-spelling

Unrecognized Spelling Error

TRANSIENTWINDOW is not a recognized word. (unrecognized-spelling)

src/cascadia/WindowsTerminal/IslandWindow.cpp

+              #include <CoreWindow.h>
+              // Define DWMSBT_TRANSIENTWINDOW if not available (for Mica Alt)
+              #ifndef DWMSBT_TRANSIENTWINDOW

Check failure

Code scanning / check-spelling

Unrecognized Spelling Error

TRANSIENTWINDOW is not a recognized word. (unrecognized-spelling)

src/cascadia/WindowsTerminal/IslandWindow.cpp

+              // Define DWMSBT_TRANSIENTWINDOW if not available (for Mica Alt)
+              #ifndef DWMSBT_TRANSIENTWINDOW
+              #define DWMSBT_TRANSIENTWINDOW 3

Check failure

Code scanning / check-spelling

Unrecognized Spelling Error

TRANSIENTWINDOW is not a recognized word. (unrecognized-spelling)

src/cascadia/WindowsTerminal/IslandWindow.cpp

+                      attribute = DWMSBT_MAINWINDOW;
+                      break;
+                  case winrt::Microsoft::Terminal::Settings::Model::MicaKind::MicaAlt:
+                      // DWMSBT_TRANSIENTWINDOW is the constant for Mica Alt

Check failure

Code scanning / check-spelling

Unrecognized Spelling Error

TRANSIENTWINDOW is not a recognized word. (unrecognized-spelling)

src/cascadia/WindowsTerminal/IslandWindow.cpp

+                      break;
+                  case winrt::Microsoft::Terminal::Settings::Model::MicaKind::MicaAlt:
+                      // DWMSBT_TRANSIENTWINDOW is the constant for Mica Alt
+                      attribute = DWMSBT_TRANSIENTWINDOW;

Check failure

Code scanning / check-spelling

Unrecognized Spelling Error

TRANSIENTWINDOW is not a recognized word. (unrecognized-spelling)

github-actions bot commented Aug 15, 2025

@check-spelling-bot Report

🔴 Please review

See the 📂 files view, the 📜action log, or 📝 job summary for details.

Unrecognized words (1)

TRANSIENTWINDOW

These words are not needed and should be removed

foob fuzzyfinder lstrcmpi oob

To accept these unrecognized words as correct and remove the previously acknowledged and now absent words, you could run the following commands

... in a clone of the git@github.com:deepanshu-maliyan/terminal.git repository
on the copilot/fix-86f3f6b9-3430-4e87-832b-22bf77fb058c branch (ℹ️ how do I use this?):

curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/v0.0.25/apply.pl' |
perl - 'https://github.com/microsoft/terminal/actions/runs/16994073668/attempts/1' &&
git commit -m 'Update check-spelling metadata'

✏️ Contributor please read this

By default the command suggestion will generate a file named based on your commit. That's generally ok as long as you add the file to your commit. Someone can reorganize it later.

If the listed items are:

... misspelled, then please correct them instead of using the command.
... names, please add them to .github/actions/spelling/allow/names.txt.
... APIs, you can add them to a file in .github/actions/spelling/allow/.
... just things you're using, please add them to an appropriate file in .github/actions/spelling/expect/.
... tokens you only need in one place and shouldn't generally be used, you can add an item in an appropriate file in .github/actions/spelling/patterns/.

See the README.md in each directory for more information.

🔬 You can test your commits without appending to a PR by creating a new branch with that extra change and pushing it to your fork. The check-spelling action will run in response to your push -- it doesn't require an open pull request. By using such a branch, you can limit the number of typos your peers see you make. 😉

If the flagged items are 🤯 false positives

If items relate to a ...

binary file (or some other file you wouldn't want to check at all).

Please add a file path to the excludes.txt file matching the containing file.

File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).
well-formed pattern.

If you can write a pattern that would match it,
try adding it to the patterns.txt file.

Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

Note that patterns can't match multiline strings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet