Skip to content

Fixed Issue #1346 child node selection, added last word handling, removed u… #1350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fixed Issue #1346 child node selection, added last word handling, removed u… #1350

wants to merge 1 commit into from

Conversation

saikishoreMSK
Copy link

…nnecessary span spaces, and added element existence checks

Description

This pull request addresses multiple issues in the typing game code, including:

  1. Child Node Selection:
  • Replaced childNodes with children in quoteElement to ensure only element nodes are selected, avoiding interference from text nodes.
  1. Handling the Last Word:
  • Added logic to handle the case when the last word is correctly typed. The game now displays a completion message and disables further input.
  1. UI Element Existence Check:
  • Added checks to ensure quoteElement, messageElement, and typedValueElement exist in the DOM before manipulation, preventing potential runtime errors.
  1. Removed Extra Spaces in span Elements:
  • Removed unnecessary spaces in generated elements for each word, ensuring accurate highlighting without display issues.

@saikishoreMSK
Fixed microsoft#1346 child node selection, added last word handling, …
5c536a6 
…removed unnecessary span spaces, and added element existence checks
@github-actions GitHub Actions
Copy link

This PR has not seen any action for a while! Closing for now, but it can be reopened at a later date.

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 5, 2025

This PR has not seen any action for a while! Closing for now, but it can be reopened at a later date.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
no-pr-activity
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@saikishoreMSK