Skip to content

Use sample aspect ratio (SAR) for thumb size calculations #1578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use sample aspect ratio (SAR) for thumb size calculations #1578

wants to merge 1 commit into from

Conversation

tim-lansen
Copy link

@tim-lansen tim-lansen commented Apr 11, 2025 •
edited
Loading

Fixes #1577

the PR:

  • encoder initialization moved to thumb_grabber_write_frame because there must be at least one decoded frame
  • using SAR unless both dimensions requested
  • added pix_fmt condition to invoke resize

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ignoring sample aspect ratio (SAR) when produce thumbnails
1 participant
@tim-lansen