Skip to content

Clarify that emulatedPosition is not true when the local-floor space is using an estimated height #871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 10, 2019
Merged

Clarify that emulatedPosition is not true when the local-floor space is using an estimated height #871

merged 1 commit into from
Oct 10, 2019

Conversation

Manishearth
Copy link
Contributor

Partially addresses #844 (we can then repurpose the issue to discuss adding an emulatedFloor)

cc @thetuvix

@Manishearth Manishearth requested a review from toji October 10, 2019 17:18
@Manishearth Manishearth mentioned this pull request Oct 10, 2019
Open
NellWaliczek
NellWaliczek approved these changes Oct 10, 2019
View reviewed changes
Copy link
Member

@NellWaliczek NellWaliczek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Manishearth Manishearth merged commit 791a15b into immersive-web:master Oct 10, 2019
@Manishearth Manishearth deleted the emulatedposition branch October 10, 2019 20:19
@toji toji added this to the October 2019 milestone Oct 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toji toji Awaiting requested review from toji

1 more reviewer

@NellWaliczek NellWaliczek NellWaliczek approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
October 2019
Development

Successfully merging this pull request may close these issues.
3 participants
@Manishearth @NellWaliczek @toji