-
Notifications
You must be signed in to change notification settings - Fork 24
feat: add indexed-to-rgb-data conversion #52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #52 +/- ##
==========================================
+ Coverage 93.44% 93.55% +0.11%
==========================================
Files 12 13 +1
Lines 1251 1319 +68
Branches 257 276 +19
==========================================
+ Hits 1169 1234 +65
- Misses 82 85 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
3d1e14e
to
b8e90a6
Compare
I also have another question: I don't remember if an indexed image can contain an alpha channel. If it's possible, we should probably return an array with the alpha values (RGBA). |
Normally indexed image contains alpha data and color data separately. But during decoding we combine them together into palette field. With current implementation I believe it should work with RGBA colors just fine. I will add some tests that check it |
No description provided.