Skip to content

Conversation

EscapedGibbon
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Jun 3, 2025

Codecov Report

Attention: Patch coverage is 95.58824% with 3 lines in your changes missing coverage. Please review.

Project coverage is 93.55%. Comparing base (8c78fbd) to head (6bccc9f).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/convertIndexedToRgb.ts 95.52% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #52      +/-   ##
==========================================
+ Coverage   93.44%   93.55%   +0.11%     
==========================================
  Files          12       13       +1     
  Lines        1251     1319      +68     
  Branches      257      276      +19     
==========================================
+ Hits         1169     1234      +65     
- Misses         82       85       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@EscapedGibbon EscapedGibbon marked this pull request as ready for review June 3, 2025 12:51
@EscapedGibbon EscapedGibbon marked this pull request as draft June 3, 2025 13:12
@EscapedGibbon EscapedGibbon marked this pull request as ready for review June 3, 2025 13:23
@EscapedGibbon EscapedGibbon requested a review from targos June 3, 2025 13:23
@EscapedGibbon EscapedGibbon requested a review from targos June 5, 2025 06:58
@targos
Copy link
Member

targos commented Jun 5, 2025

I also have another question: I don't remember if an indexed image can contain an alpha channel. If it's possible, we should probably return an array with the alpha values (RGBA).

@EscapedGibbon
Copy link
Contributor Author

I also have another question: I don't remember if an indexed image can contain an alpha channel. If it's possible, we should probably return an array with the alpha values (RGBA).

Normally indexed image contains alpha data and color data separately. But during decoding we combine them together into palette field. With current implementation I believe it should work with RGBA colors just fine. I will add some tests that check it

@EscapedGibbon EscapedGibbon marked this pull request as draft June 5, 2025 09:22
@EscapedGibbon EscapedGibbon marked this pull request as ready for review June 5, 2025 23:34
@EscapedGibbon EscapedGibbon requested a review from targos June 6, 2025 08:45
@targos targos merged commit bbfd8fc into main Jun 11, 2025
9 checks passed
@targos targos deleted the indexed-to-rgb branch June 11, 2025 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants