Add service modbus.read_registers
#151769
Open
+271
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
crug80
reviewed
Sep 6, 2025
| @@ -13,6 +13,7 @@ | |||
| It uses binary_sensors/sensors to do black box testing of the read calls. | |||
| """ | |||
|
|
|||
| from contextlib import nullcontext as does_not_raise | |||
There was a problem hiding this comment.
In the past, the use of contextlib was not encouraged. I don't know if this is changed now.
There was a problem hiding this comment.
Thanks for reviewing.
As far as I can tell, that comment was specifically about contextlib.suppress.
Here, I am just using contextlib.nullcontext to disable the pytest.raises() if I do not expect the service call to error out. It seemed cleaner than duplicating the hass.services.async_call line.
This pattern seems to be somewhat common in tests, see e.g. https://github.com/home-assistant/core/blob/6a1629d2ed6ea3473544a3e6dc5fd188f97f0445/tests/components/recorder/test_backup.py
However, I am no expert.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Sometimes it is useful to be able to read input or holding registers without creating a new entity with polling for them. Examples include peeking at configuration registers that only need to be read once during the commissioning of a new device.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: